Re: [PATCH V1] da9052: ONKEY: use correct register bit for key status

On Tue, Feb 11, 2014 at 04:57:47PM +, Opensource [Anthony Olech] wrote: > > -Original Message- > > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > > Sent: 11 February 2014 16:29 > ..[snip].. > > > static void da9052_onkey_query(struct da9052_onkey *onkey) { > > > - int

RE: [PATCH V1] da9052: ONKEY: use correct register bit for key status

> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: 11 February 2014 16:29 ..[snip].. > > static void da9052_onkey_query(struct da9052_onkey *onkey) { > > - int key_stat; > > + int ret, key_stat; > > > > - key_stat =

Re: [PATCH V1] da9052: ONKEY: use correct register bit for key status

Hi Anthony, On Thu, Feb 06, 2014 at 03:19:49PM +, Anthony Olech wrote: > The wrong register bit of the DA9052/3 PMIC registers was > used to determine the status on the ONKEY. > > Signed-off-by: Anthony Olech > Signed-off-by: David Dajun Chen > --- > > This patch is relative to

Re: [PATCH V1] da9052: ONKEY: use correct register bit for key status

Hi Anthony, On Thu, Feb 06, 2014 at 03:19:49PM +, Anthony Olech anthony.olech.opensou...@diasemi.com wrote: The wrong register bit of the DA9052/3 PMIC registers was used to determine the status on the ONKEY. Signed-off-by: Anthony Olech anthony.olech.opensou...@diasemi.com

Re: [PATCH V1] da9052: ONKEY: use correct register bit for key status

On Tue, Feb 11, 2014 at 04:57:47PM +, Opensource [Anthony Olech] wrote: -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: 11 February 2014 16:29 ..[snip].. static void da9052_onkey_query(struct da9052_onkey *onkey) { - int key_stat; +

RE: [PATCH V1] da9052: ONKEY: use correct register bit for key status

-Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: 11 February 2014 16:29 ..[snip].. static void da9052_onkey_query(struct da9052_onkey *onkey) { - int key_stat; + int ret, key_stat; - key_stat = da9052_reg_read(onkey-da9052,