Hi Wu,
On 06/01/2017 02:30 AM, Wu Fenglin wrote:
> Thanks Pavel.
> I will remove these two dts properties and define the default on/off time
> values in C code.
There are many things to sort out regarding your patch. I'll be able to
give you a detailed feedback probably no sooner than at the week
Thanks Pavel.
I will remove these two dts properties and define the default on/off time
values in C code.
--
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux
Foundation Collaborative Project.
Hi!
> Thanks for the reviewing.
>
> For the order, the hardware register mapping has this order (blue/green/red)
> from bit0/1/2, I can revert it to (red/green/blue) if there is a strong
> concern.
I'd do that.
> For these two properties: qcom,off-ms/ qcom,on-ms, I am using them to assign
> the
el.org; linux-kernel@vger.kernel.org; Richard
Purdie ; Jacek Anaszewski ;
Rob Herring ; Mark Rutland ;
linux-l...@vger.kernel.org; devicet...@vger.kernel.org;
subba...@quicinc.com; agha...@qti.qualcomm.com; wr...@quicinc.com;
kgu...@qti.qualcomm.com
Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add L
Hi!
> +- qcom,support-blink:
> + Usage: optional
> + Value type:
> + Definition: An array of integer values to indicate if "blue", "green",
> "red"
> + LEDs support blink control. The values are listed as the fixed
> + order for "blue", "green", "red" LEDs.
N
5 matches
Mail list logo
