Re: [PATCH V1 3/3] regulator: slg51000: add slg51000 regulator driver

2019-04-17 Thread Mark Brown
On Wed, Apr 17, 2019 at 11:25:29AM +, Eric Hyeung Dong Jeong wrote: > On Wednesday, April 17, 2019 12:25 AM +0900, Mark Brown wrote: > > This looks like it should be a get_status() operation as it's reading > > status bits rather than the command we sent to the device - for that > > just use r

RE: [PATCH V1 3/3] regulator: slg51000: add slg51000 regulator driver

2019-04-17 Thread Eric Hyeung Dong Jeong
On Wednesday, April 17, 2019 12:25 AM +0900, Mark Brown wrote: > On Tue, Apr 16, 2019 at 01:37:27PM +0900, Eric Jeong wrote: > > > +static int slg51000_regulator_is_enabled(struct regulator_dev *rdev) > > +{ > > + struct slg51000 *chip = rdev_get_drvdata(rdev); > > + int ret, id = rdev_get_i

Re: [PATCH V1 3/3] regulator: slg51000: add slg51000 regulator driver

2019-04-16 Thread Mark Brown
On Tue, Apr 16, 2019 at 01:37:27PM +0900, Eric Jeong wrote: > +static int slg51000_regulator_is_enabled(struct regulator_dev *rdev) > +{ > + struct slg51000 *chip = rdev_get_drvdata(rdev); > + int ret, id = rdev_get_id(rdev); > + unsigned int state; > + > + ret = regmap_read(chip->