Re: [PATCH V15 3/6] i2c: tegra: fix maximum transfer size

2019-02-08 Thread Dmitry Osipenko
08.02.2019 18:25, Sowjanya Komatineni пишет: >> 08.02.2019 17:12, Peter Rosin пишет: >>> On 2019-02-08 13:46, Dmitry Osipenko wrote: 08.02.2019 1:25, Dmitry Osipenko пишет: >> 08.02.2019 1:16, Sowjanya Komatineni пишет:> This is wrong, 65535 = 64 * 1024 - 1. Let'

RE: [PATCH V15 3/6] i2c: tegra: fix maximum transfer size

2019-02-08 Thread Sowjanya Komatineni
> 08.02.2019 17:12, Peter Rosin пишет: > > On 2019-02-08 13:46, Dmitry Osipenko wrote: > >> 08.02.2019 1:25, Dmitry Osipenko пишет: > 08.02.2019 1:16, Sowjanya Komatineni пишет:> > >> This is wrong, 65535 = 64 * 1024 - 1. > >> > >> Let's just use size-constants provided by kernel:

Re: [PATCH V15 3/6] i2c: tegra: fix maximum transfer size

2019-02-08 Thread Dmitry Osipenko
08.02.2019 17:12, Peter Rosin пишет: > On 2019-02-08 13:46, Dmitry Osipenko wrote: >> 08.02.2019 1:25, Dmitry Osipenko пишет: 08.02.2019 1:16, Sowjanya Komatineni пишет:> >> This is wrong, 65535 = 64 * 1024 - 1. >> >> Let's just use size-constants provided by kernel: >> >>

Re: [PATCH V15 3/6] i2c: tegra: fix maximum transfer size

2019-02-08 Thread Peter Rosin
On 2019-02-08 13:46, Dmitry Osipenko wrote: > 08.02.2019 1:25, Dmitry Osipenko пишет: >>> 08.02.2019 1:16, Sowjanya Komatineni пишет:> > This is wrong, 65535 = 64 * 1024 - 1. > > Let's just use size-constants provided by kernel: > > static const struct i2c_adapter_quirks tegra_

Re: [PATCH V15 3/6] i2c: tegra: fix maximum transfer size

2019-02-08 Thread Dmitry Osipenko
08.02.2019 1:25, Dmitry Osipenko пишет: >> 08.02.2019 1:16, Sowjanya Komatineni пишет:> This is wrong, 65535 = 64 * 1024 - 1. Let's just use size-constants provided by kernel: static const struct i2c_adapter_quirks tegra_i2c_quirks = { .flags = I2C_AQ_NO_ZERO_LEN,

Re: [PATCH V15 3/6] i2c: tegra: fix maximum transfer size

2019-02-07 Thread Dmitry Osipenko
> 08.02.2019 1:16, Sowjanya Komatineni пишет:> >>> This is wrong, 65535 = 64 * 1024 - 1. >>> >>> Let's just use size-constants provided by kernel: >>> >>> static const struct i2c_adapter_quirks tegra_i2c_quirks = { >>> .flags = I2C_AQ_NO_ZERO_LEN, >>> .max_read_len = SZ_4K, >>> .max_wr

Re: [PATCH V15 3/6] i2c: tegra: fix maximum transfer size

2019-02-07 Thread Dmitry Osipenko
08.02.2019 0:47, Sowjanya Komatineni пишет: > Tegra194 supports maximum 64K bytes transfer per packet. > Tegra186 and prior supports maximum 4K bytes transfer per packet. > This includes 12 bytes of packet header. > > This patch fixes max write length to account for packet header size > for transf