RE: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Anson Huang
lists.infradead.org; linux- > ker...@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support > > On Wed, Mar 13, 2019 at 07:31:16AM +, Anson Huang wrote: > > i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) > >

RE: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Anson Huang
lists.infradead.org; linux- > ker...@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support > > Hello, > > On Thu, Mar 14, 2019 at 09:49:06AM +, Anson Huang wrote: > > > On Wed, Mar 13, 2019 at 07:31:16AM +, Anson

Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Uwe Kleine-König
Hello, On Thu, Mar 14, 2019 at 09:49:06AM +, Anson Huang wrote: > > On Wed, Mar 13, 2019 at 07:31:16AM +, Anson Huang wrote: > > > +static void imx_tpm_pwm_config(struct pwm_chip *chip, > > > +struct pwm_device *pwm, > > > +struct pwm_state *

RE: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Anson Huang
lists.infradead.org; linux- > ker...@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support > > On Wed, Mar 13, 2019 at 07:31:16AM +, Anson Huang wrote: > > i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) > >

Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Uwe Kleine-König
On Thu, Mar 14, 2019 at 10:17:02AM +0100, Uwe Kleine-König wrote: > I didn't look in depth through the complete driver yet, but there is > IIRC still some feedback on v1 that wasn't addressed in v2 (because v2 > was sent before the last feedback). So I will look in more depth in v3 > (assuming it c

Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Uwe Kleine-König
On Wed, Mar 13, 2019 at 07:31:16AM +, Anson Huang wrote: > i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) > inside, add TPM PWM driver support. > > Signed-off-by: Anson Huang > --- > Changes since V1: > - improve coding style, function name's prefix; > - improve K