RE: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-22 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > On Wed, 14 Jun 2017 00:10:28 +0100 > Salil Mehta <salil.me...@huawei.com> wrote: > > > +hns3_nic_get_stats64(

RE: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-22 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > On Wed, 14 Jun 2017 00:10:28 +0100 > Salil Mehta wrote: > > > +hns3_nic_get_stats64(struct net_de

Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-19 Thread Stephen Hemminger
On Wed, 14 Jun 2017 00:10:28 +0100 Salil Mehta wrote: > +hns3_nic_get_stats64(struct net_device *ndev, struct rtnl_link_stats64 > *stats) > +{ > + struct hns3_nic_priv *priv = netdev_priv(ndev); > + int queue_num = priv->ae_handle->kinfo.num_tqps; > + u64

Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-19 Thread Stephen Hemminger
On Wed, 14 Jun 2017 00:10:28 +0100 Salil Mehta wrote: > +hns3_nic_get_stats64(struct net_device *ndev, struct rtnl_link_stats64 > *stats) > +{ > + struct hns3_nic_priv *priv = netdev_priv(ndev); > + int queue_num = priv->ae_handle->kinfo.num_tqps; > + u64 tx_bytes = 0; > + u64

RE: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-17 Thread Salil Mehta
.kernel.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > On Wed, 14 Jun 2017 00:10:28 +0100 > Salil Mehta <salil.me...@huawei.com> wrote: > > > +st

RE: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-17 Thread Salil Mehta
.kernel.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > On Wed, 14 Jun 2017 00:10:28 +0100 > Salil Mehta wrote: > > > +static irqreturn_t hns3_irq_han

Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-13 Thread Stephen Hemminger
On Wed, 14 Jun 2017 00:10:28 +0100 Salil Mehta wrote: > +static irqreturn_t hns3_irq_handle(int irq, void *dev) > +{ > + struct hns3_enet_tqp_vector *tqp_vector = dev; > + > + napi_schedule(_vector->napi); In order to do NAPI correctly, the IRQ must be disabled.

Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-13 Thread Stephen Hemminger
On Wed, 14 Jun 2017 00:10:28 +0100 Salil Mehta wrote: > +static irqreturn_t hns3_irq_handle(int irq, void *dev) > +{ > + struct hns3_enet_tqp_vector *tqp_vector = dev; > + > + napi_schedule(_vector->napi); In order to do NAPI correctly, the IRQ must be disabled. If you are using MSI,