Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
@vger.kernel.org; linux- +a...@vger.kernel.org; Loc Ho; Thang Nguyen; patches; Tin Huynh +Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x + +Hi Phong, + +On 11/30/2016 09:23 AM, Phong Vo wrote: +> +-Original Message- +> +From: Jacek Anaszewski [mailto:j.anaszew...@samsu

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
@vger.kernel.org; linux- +a...@vger.kernel.org; Loc Ho; Thang Nguyen; patches; Tin Huynh +Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x + +Hi Phong, + +On 11/30/2016 09:23 AM, Phong Vo wrote: +> +-Original Message- +> +From: Jacek Anaszewski [mailto:j.anaszew...@samsu

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Mika Westerberg
On Wed, Nov 30, 2016 at 10:58:33AM +0100, Jacek Anaszewski wrote: > It certainly downgrades code readability, but in case there is > similar surrounding code there are two options to keep the things > consistent - either stick to the current style or change it. > IMHO the latter would generate

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Mika Westerberg
On Wed, Nov 30, 2016 at 10:58:33AM +0100, Jacek Anaszewski wrote: > It certainly downgrades code readability, but in case there is > similar surrounding code there are two options to keep the things > consistent - either stick to the current style or change it. > IMHO the latter would generate

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
Hi Peter, On 11/30/2016 10:36 AM, Peter Rosin wrote: On 2016-11-30 10:10, Phong Vo wrote: +-Original Message- +From: Jacek Anaszewski [mailto:j.anaszew...@samsung.com] + +Hi Phong, + +On 11/30/2016 09:23 AM, Phong Vo wrote: +> +-Original Message- +> +From: Jacek Anaszewski

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
Hi Peter, On 11/30/2016 10:36 AM, Peter Rosin wrote: On 2016-11-30 10:10, Phong Vo wrote: +-Original Message- +From: Jacek Anaszewski [mailto:j.anaszew...@samsung.com] + +Hi Phong, + +On 11/30/2016 09:23 AM, Phong Vo wrote: +> +-Original Message- +> +From: Jacek Anaszewski

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Peter Rosin
On 2016-11-30 10:10, Phong Vo wrote: > +-Original Message- > +From: Jacek Anaszewski [mailto:j.anaszew...@samsung.com] > + > +Hi Phong, > + > +On 11/30/2016 09:23 AM, Phong Vo wrote: > +> +-Original Message- > +> +From: Jacek Anaszewski [mailto:j.anaszew...@samsung.com] > +> + > +>

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Peter Rosin
On 2016-11-30 10:10, Phong Vo wrote: > +-Original Message- > +From: Jacek Anaszewski [mailto:j.anaszew...@samsung.com] > + > +Hi Phong, > + > +On 11/30/2016 09:23 AM, Phong Vo wrote: > +> +-Original Message- > +> +From: Jacek Anaszewski [mailto:j.anaszew...@samsung.com] > +> + > +>

RE: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Phong Vo
; Thang Nguyen; patches; Tin Huynh +Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x + +Hi Phong, + +On 11/30/2016 09:23 AM, Phong Vo wrote: +> +-Original Message- +> +From: Jacek Anaszewski [mailto:j.anaszew...@samsung.com] +> +Sent: Wednesday, November 30, 201

RE: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Phong Vo
; Thang Nguyen; patches; Tin Huynh +Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x + +Hi Phong, + +On 11/30/2016 09:23 AM, Phong Vo wrote: +> +-Original Message- +> +From: Jacek Anaszewski [mailto:j.anaszew...@samsung.com] +> +Sent: Wednesday, November 30, 201

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
@vger.kernel.org; linux- +a...@vger.kernel.org; Loc Ho; Thang Nguyen; Phong Vo; patches +Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x + +On 11/30/2016 09:06 AM, Tin Huynh wrote: +> On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski +> <j.anaszew...@samsung.c

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
@vger.kernel.org; linux- +a...@vger.kernel.org; Loc Ho; Thang Nguyen; Phong Vo; patches +Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x + +On 11/30/2016 09:06 AM, Tin Huynh wrote: +> On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski +> wrote: +>> +>> On 1

RE: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Phong Vo
; Thang Nguyen; Phong Vo; patches +Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x + +On 11/30/2016 09:06 AM, Tin Huynh wrote: +> On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski +> <j.anaszew...@samsung.com> wrote: +>> +>> On 11/30/2016 08:51 AM

RE: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Phong Vo
; Thang Nguyen; Phong Vo; patches +Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x + +On 11/30/2016 09:06 AM, Tin Huynh wrote: +> On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski +> wrote: +>> +>> On 11/30/2016 08:51 AM, Jacek Anaszewski wrote: +>>>

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
On 11/30/2016 09:06 AM, Tin Huynh wrote: On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski wrote: On 11/30/2016 08:51 AM, Jacek Anaszewski wrote: Hi Tin, How this patch is different from the one already merged? Best regards, Jacek Anaszewski On 11/30/2016 04:08

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
On 11/30/2016 09:06 AM, Tin Huynh wrote: On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski wrote: On 11/30/2016 08:51 AM, Jacek Anaszewski wrote: Hi Tin, How this patch is different from the one already merged? Best regards, Jacek Anaszewski On 11/30/2016 04:08 AM, Tin Huynh wrote:

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Tin Huynh
On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski wrote: > > On 11/30/2016 08:51 AM, Jacek Anaszewski wrote: >> >> Hi Tin, >> >> How this patch is different from the one already merged? >> >> Best regards, >> Jacek Anaszewski >> >> On 11/30/2016 04:08 AM, Tin Huynh

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Tin Huynh
On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski wrote: > > On 11/30/2016 08:51 AM, Jacek Anaszewski wrote: >> >> Hi Tin, >> >> How this patch is different from the one already merged? >> >> Best regards, >> Jacek Anaszewski >> >> On 11/30/2016 04:08 AM, Tin Huynh wrote: >>> >>> This patch

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
On 11/30/2016 08:51 AM, Jacek Anaszewski wrote: Hi Tin, How this patch is different from the one already merged? Best regards, Jacek Anaszewski On 11/30/2016 04:08 AM, Tin Huynh wrote: This patch enables ACPI support for leds-pca955x driver. Signed-off-by: Tin Huynh ---

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-30 Thread Jacek Anaszewski
On 11/30/2016 08:51 AM, Jacek Anaszewski wrote: Hi Tin, How this patch is different from the one already merged? Best regards, Jacek Anaszewski On 11/30/2016 04:08 AM, Tin Huynh wrote: This patch enables ACPI support for leds-pca955x driver. Signed-off-by: Tin Huynh ---

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-29 Thread Jacek Anaszewski
Hi Tin, How this patch is different from the one already merged? Best regards, Jacek Anaszewski On 11/30/2016 04:08 AM, Tin Huynh wrote: This patch enables ACPI support for leds-pca955x driver. Signed-off-by: Tin Huynh --- drivers/leds/leds-pca955x.c | 22

Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

2016-11-29 Thread Jacek Anaszewski
Hi Tin, How this patch is different from the one already merged? Best regards, Jacek Anaszewski On 11/30/2016 04:08 AM, Tin Huynh wrote: This patch enables ACPI support for leds-pca955x driver. Signed-off-by: Tin Huynh --- drivers/leds/leds-pca955x.c | 22 +- 1 files