Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Thu, 2019-08-29 at 02:49 +, Anson Huang wrote: > Hi, Rui > > > > On Wed, 2019-08-28 at 08:51 +, Anson Huang wrote: > > > > Hi, Rui > > > > > > > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > > > > In an earli

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Anson Huang
Hi, Rui > > On Wed, 2019-08-28 at 08:51 +, Anson Huang wrote: > > > Hi, Rui > > > > > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > > > In an earlier series the CLK_IS_CRITICAL flags was removed > > > > > > > from the

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Anson Huang
Hi, Rui > On Wed, 2019-08-28 at 08:49 +, Anson Huang wrote: > > Hi, Rui > > > > > On Wed, 2019-08-28 at 16:32 +0800, Zhang Rui wrote: > > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > > > In an earlier series the CLK_I

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Anson Huang
Hi, Rui > On Wed, 2019-08-28 at 08:51 +, Anson Huang wrote: > > Hi, Rui > > > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > > In an earlier series the CLK_IS_CRITICAL flags was removed > > > > > > from the TMU clock so i

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Wed, 2019-08-28 at 08:51 +, Anson Huang wrote: > Hi, Rui > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > In an earlier series the CLK_IS_CRITICAL flags was removed > > > > > from > > > > > the TMU clock so if the therma

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Wed, 2019-08-28 at 08:49 +, Anson Huang wrote: > Hi, Rui > > > On Wed, 2019-08-28 at 16:32 +0800, Zhang Rui wrote: > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > > In an earlier series the CLK_IS_CRITICAL flags was r

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Anson Huang
Hi, Rui > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > On 27.08.2019 04:51, Anson Huang wrote: > > > > In an earlier series the CLK_IS_CRITICAL flags was removed from > > > > the TMU clock so if the thermal driver doesn't explicitly enable > > > > it the system will hang on probe.

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Anson Huang
Hi, Rui > On Wed, 2019-08-28 at 16:32 +0800, Zhang Rui wrote: > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > In an earlier series the CLK_IS_CRITICAL flags was removed from > > > > > the TMU clock so if the thermal driver doesn

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Wed, 2019-08-28 at 16:32 +0800, Zhang Rui wrote: > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > On 27.08.2019 04:51, Anson Huang wrote: > > > > In an earlier series the CLK_IS_CRITICAL flags was removed from > > > > the TMU > > > > clock so if the thermal driver doesn't explicit

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > On 27.08.2019 04:51, Anson Huang wrote: > > > In an earlier series the CLK_IS_CRITICAL flags was removed from > > > the TMU > > > clock so if the thermal driver doesn't explicitly enable it the > > > system will hang > > > on probe. This i

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-27 Thread Leonard Crestez
On 27.08.2019 04:51, Anson Huang wrote: >> In an earlier series the CLK_IS_CRITICAL flags was removed from the TMU >> clock so if the thermal driver doesn't explicitly enable it the system will >> hang >> on probe. This is what happens in linux-next right now! > > The thermal driver should be bui

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-26 Thread Anson Huang
Hi, Rui > On Tue, 2019-08-27 at 01:51 +, Anson Huang wrote: > > > On 7/30/2019 5:31 AM, anson.hu...@nxp.com wrote: > > > > From: Anson Huang > > > > > > > > Some platforms like i.MX8MQ has clock control for this module, > > > > need to add clock operations to make sure the driver is working >

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-26 Thread Zhang Rui
On Tue, 2019-08-27 at 01:51 +, Anson Huang wrote: > > On 7/30/2019 5:31 AM, anson.hu...@nxp.com wrote: > > > From: Anson Huang > > > > > > Some platforms like i.MX8MQ has clock control for this module, > > > need to > > > add clock operations to make sure the driver is working properly. > > >

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-26 Thread Anson Huang
> On 7/30/2019 5:31 AM, anson.hu...@nxp.com wrote: > > From: Anson Huang > > > > Some platforms like i.MX8MQ has clock control for this module, need to > > add clock operations to make sure the driver is working properly. > > > > Signed-off-by: Anson Huang > > Reviewed-by: Guido Günther > > T

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-26 Thread Leonard Crestez
On 7/30/2019 5:31 AM, anson.hu...@nxp.com wrote: > From: Anson Huang > > Some platforms like i.MX8MQ has clock control for this module, > need to add clock operations to make sure the driver is working > properly. > > Signed-off-by: Anson Huang > Reviewed-by: Guido Günther This series looks g

RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-05 Thread Aisheng Dong
> From: Anson Huang > > Some platforms like i.MX8MQ has clock control for this module, need to add > clock operations to make sure the driver is working properly. > > Signed-off-by: Anson Huang > Reviewed-by: Guido Günther Reviewed-by: Dong Aisheng Regards Aisheng