Re: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module

2020-06-11 Thread Daniel Baluta
On 11.06.2020 11:44, Anson Huang wrote: Hi, Daniel Subject: Re: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module Hi Anson, Patch series mostly looks good to me. I have a comment about adding the MODULE_LICENSE. This is a pretty important change. Can you please add

RE: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module

2020-06-11 Thread Anson Huang
Hi, Daniel > Subject: Re: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module > > Hi Anson, > > Patch series mostly looks good to me. I have a comment about adding > > the MODULE_LICENSE. This is a pretty important change. > > > Can you please

Re: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module

2020-06-11 Thread Daniel Baluta
Hi Anson, Patch series mostly looks good to me. I have a comment about adding the MODULE_LICENSE. This is a pretty important change. Can you please add this change in a separate patch with a proper explanation of why it is needed. Most likely it is because it was forgotten in the previous