On Wed, May 1, 2013 at 11:48 PM, Huang Shijie wrote:
> 于 2013年05月02日 14:17, Gupta, Pekon 写道:
>
>> [Pekon]: onfi_feature() is actually not useful unless someone re-scans the
>
> I do not think so. :)
>
> I think the onfi_feature() is useful in the future.
> I only add the two feauture for this help
于 2013年05月02日 14:17, Gupta, Pekon 写道:
[Pekon]: onfi_feature() is actually not useful unless someone re-scans the
I do not think so. :)
I think the onfi_feature() is useful in the future.
I only add the two feauture for this helper:
[1] 16-bit and
[2] extended parameter page
But in actually
> 于 2013年05月02日 13:42, Gupta, Pekon 写道:
> -*busw = 0;
> -if (le16_to_cpu(p->features)& 1)
> -*busw = NAND_BUSWIDTH_16;
> +
> +*busw = (onfi_feature(chip)& ONFI_FEATURE_16_BIT_BUS) ?
> +NAND_BUSWIDTH_16
于 2013年05月02日 13:42, Gupta, Pekon 写道:
- *busw = 0;
- if (le16_to_cpu(p->features)& 1)
- *busw = NAND_BUSWIDTH_16;
+
+ *busw = (onfi_feature(chip)& ONFI_FEATURE_16_BIT_BUS) ?
+ NAND_BUSWIDTH_16 : 0;
Is this really needed ? you have already
> >> - *busw = 0;
> >> - if (le16_to_cpu(p->features)& 1)
> >> - *busw = NAND_BUSWIDTH_16;
> >> +
> >> + *busw = (onfi_feature(chip)& ONFI_FEATURE_16_BIT_BUS) ?
> >> + NAND_BUSWIDTH_16 : 0;
> > Is this really needed ? you have already checked the 'onfi_version'
> abov
于 2013年04月30日 18:04, Gupta, Pekon 写道:
- *busw = 0;
- if (le16_to_cpu(p->features)& 1)
- *busw = NAND_BUSWIDTH_16;
+
+ *busw = (onfi_feature(chip)& ONFI_FEATURE_16_BIT_BUS) ?
+ NAND_BUSWIDTH_16 : 0;
Is this really needed ? you have already c
> - *busw = 0;
> - if (le16_to_cpu(p->features) & 1)
> - *busw = NAND_BUSWIDTH_16;
> +
> + *busw = (onfi_feature(chip) & ONFI_FEATURE_16_BIT_BUS) ?
> + NAND_BUSWIDTH_16 : 0;
Is this really needed ? you have already checked the 'onfi_version' above in
nan
7 matches
Mail list logo