RE: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Salil Mehta
(Y); > mehta.salil@gmail.com; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to > HNS3 Ethernet driver for hip08 SoC > > > +int hclge

RE: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Salil Mehta
(Y); > mehta.salil@gmail.com; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to > HNS3 Ethernet driver for hip08 SoC > > > +int hclge

RE: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to > HNS3 Ethernet driver for hip08 SoC > > > +static void hclge_mac_adjust_link(struct net_device *netdev) > > +{ > > + struct

RE: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to > HNS3 Ethernet driver for hip08 SoC > > > +static void hclge_mac_adjust_link(struct net_device *netdev) > > +{ > > + struct

Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Andrew Lunn
> +int hclge_mac_mdio_config(struct hclge_dev *hdev) > +{ .. > +} > + > +int hclge_mac_start_phy(struct hclge_dev *hdev) > +{ > +} > + > +void hclge_mac_stop_phy(struct hclge_dev *hdev) > +{ > +} > -- These are not static functions. So i would expect them to be in a header file somewhere

Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Andrew Lunn
> +int hclge_mac_mdio_config(struct hclge_dev *hdev) > +{ .. > +} > + > +int hclge_mac_start_phy(struct hclge_dev *hdev) > +{ > +} > + > +void hclge_mac_stop_phy(struct hclge_dev *hdev) > +{ > +} > -- These are not static functions. So i would expect them to be in a header file somewhere

Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Andrew Lunn
> +static void hclge_mac_adjust_link(struct net_device *netdev) > +{ > + struct hnae3_handle *h = *((void **)netdev_priv(netdev)); > + struct hclge_vport *vport = hclge_get_vport(h); > + struct hclge_dev *hdev = vport->back; > + int duplex, speed; > + int ret; > + > + speed

Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Andrew Lunn
> +static void hclge_mac_adjust_link(struct net_device *netdev) > +{ > + struct hnae3_handle *h = *((void **)netdev_priv(netdev)); > + struct hclge_vport *vport = hclge_get_vport(h); > + struct hclge_dev *hdev = vport->back; > + int duplex, speed; > + int ret; > + > + speed