Re: [PATCH V6 2/3] perf tools: parse the pmu event prefix and surfix

2014-10-03 Thread Jiri Olsa
On Thu, Oct 02, 2014 at 05:33:07PM +, Liang, Kan wrote: > > > > > > > > +static int > > > +comp_pmu(const void *p1, const void *p2) { > > > + struct perf_pmu_event_symbol *pmu1 = > > > + (struct perf_pmu_event_symbol *) p1; > > > + struct perf_pmu_event_symbol *pmu2 = > > > +

Re: [PATCH V6 2/3] perf tools: parse the pmu event prefix and surfix

2014-10-03 Thread Jiri Olsa
On Thu, Oct 02, 2014 at 05:33:07PM +, Liang, Kan wrote: +static int +comp_pmu(const void *p1, const void *p2) { + struct perf_pmu_event_symbol *pmu1 = + (struct perf_pmu_event_symbol *) p1; + struct perf_pmu_event_symbol *pmu2 = +

RE: [PATCH V6 2/3] perf tools: parse the pmu event prefix and surfix

2014-10-02 Thread Liang, Kan
> > > > +static int > > +comp_pmu(const void *p1, const void *p2) { > > + struct perf_pmu_event_symbol *pmu1 = > > + (struct perf_pmu_event_symbol *) p1; > > + struct perf_pmu_event_symbol *pmu2 = > > + (struct perf_pmu_event_symbol *) p2; > > please keep

RE: [PATCH V6 2/3] perf tools: parse the pmu event prefix and surfix

2014-10-02 Thread Liang, Kan
+static int +comp_pmu(const void *p1, const void *p2) { + struct perf_pmu_event_symbol *pmu1 = + (struct perf_pmu_event_symbol *) p1; + struct perf_pmu_event_symbol *pmu2 = + (struct perf_pmu_event_symbol *) p2; please keep it on one line,

Re: [PATCH V6 2/3] perf tools: parse the pmu event prefix and surfix

2014-09-14 Thread Jiri Olsa
On Thu, Sep 11, 2014 at 03:08:58PM -0400, kan.li...@intel.com wrote: > From: Kan Liang typo in subject - s/surfix/suffix/ SNIP > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index b9174bc..20e01d1 100644 > --- a/tools/perf/util/parse-events.c > +++

Re: [PATCH V6 2/3] perf tools: parse the pmu event prefix and surfix

2014-09-14 Thread Jiri Olsa
On Thu, Sep 11, 2014 at 03:08:58PM -0400, kan.li...@intel.com wrote: From: Kan Liang kan.li...@intel.com typo in subject - s/surfix/suffix/ SNIP diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index b9174bc..20e01d1 100644 --- a/tools/perf/util/parse-events.c