Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Arnaldo Carvalho de Melo
Em Thu, May 07, 2015 at 07:37:50PM +0200, Peter Zijlstra escreveu: > On Thu, May 07, 2015 at 01:22:23PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, May 07, 2015 at 04:39:39PM +0200, Peter Zijlstra escreveu: > > > On Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo wrote: > >

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
On Thu, May 07, 2015 at 01:22:23PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, May 07, 2015 at 04:39:39PM +0200, Peter Zijlstra escreveu: > > On Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: > >

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Arnaldo Carvalho de Melo
Em Thu, May 07, 2015 at 04:39:39PM +0200, Peter Zijlstra escreveu: > On Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: > > > On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: > > > > > > >

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
On Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: > > On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: > > > > > > - dropped the @id field from the record, it is already included in the >

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Arnaldo Carvalho de Melo
Em Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: > > On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: > > > > > > - dropped the @id field from the record, it is already included in the

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Arnaldo Carvalho de Melo
Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: > On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: > > > > - dropped the @id field from the record, it is already included in the > >@sample_id values. > > Hmm, this would force people to use sample_id; which

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
On Thu, May 07, 2015 at 01:56:09PM +, Liang, Kan wrote: > > > > > > > So I changed it slightly to the below; changes are: > > > > - record 'lost' events to all set bits; after all we really do not > >know which event this sample belonged to, only logging to the first > >set bit

RE: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Liang, Kan
> > > So I changed it slightly to the below; changes are: > > - record 'lost' events to all set bits; after all we really do not >know which event this sample belonged to, only logging to the first >set bit seems 'wrong'. If so, the same dropped sample will be count multiple times.

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: > > - dropped the @id field from the record, it is already included in the >@sample_id values. Hmm, this would force people to use sample_id; which in general is a good idea, but should we really force that on people? Acme? --

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
So I changed it slightly to the below; changes are: - record 'lost' events to all set bits; after all we really do not know which event this sample belonged to, only logging to the first set bit seems 'wrong'. - dropped the @id field from the record, it is already included in the

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Arnaldo Carvalho de Melo
Em Thu, May 07, 2015 at 07:37:50PM +0200, Peter Zijlstra escreveu: On Thu, May 07, 2015 at 01:22:23PM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, May 07, 2015 at 04:39:39PM +0200, Peter Zijlstra escreveu: On Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo wrote: Em

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: - dropped the @id field from the record, it is already included in the @sample_id values. Hmm, this would force people to use sample_id; which in general is a good idea, but should we really force that on people? Acme? -- To

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
So I changed it slightly to the below; changes are: - record 'lost' events to all set bits; after all we really do not know which event this sample belonged to, only logging to the first set bit seems 'wrong'. - dropped the @id field from the record, it is already included in the

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Arnaldo Carvalho de Melo
Em Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo escreveu: Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: - dropped the @id field from the record, it is already included in the

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
On Thu, May 07, 2015 at 01:56:09PM +, Liang, Kan wrote: So I changed it slightly to the below; changes are: - record 'lost' events to all set bits; after all we really do not know which event this sample belonged to, only logging to the first set bit seems 'wrong'.

RE: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Liang, Kan
So I changed it slightly to the below; changes are: - record 'lost' events to all set bits; after all we really do not know which event this sample belonged to, only logging to the first set bit seems 'wrong'. If so, the same dropped sample will be count multiple times. It's

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Arnaldo Carvalho de Melo
Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: - dropped the @id field from the record, it is already included in the @sample_id values. Hmm, this would force people to use sample_id; which in

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Arnaldo Carvalho de Melo
Em Thu, May 07, 2015 at 04:39:39PM +0200, Peter Zijlstra escreveu: On Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: - dropped

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
On Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: - dropped the @id field from the record, it is already included in the

Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES

2015-05-07 Thread Peter Zijlstra
On Thu, May 07, 2015 at 01:22:23PM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, May 07, 2015 at 04:39:39PM +0200, Peter Zijlstra escreveu: On Thu, May 07, 2015 at 11:15:20AM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: On