RE: [PATCH bpf-next 2/6] bpf: sockmap: merge sockmap and sockhash update functions

2020-08-19 Thread John Fastabend
Lorenz Bauer wrote: > Merge the two very similar functions sock_map_update_elem and > sock_hash_update_elem into one. > > Signed-off-by: Lorenz Bauer > --- > net/core/sock_map.c | 53 - > 1 file changed, 9 insertions(+), 44 deletions(-) > Fixup the w

Re: [PATCH bpf-next 2/6] bpf: sockmap: merge sockmap and sockhash update functions

2020-08-19 Thread Yonghong Song
On 8/19/20 2:24 AM, Lorenz Bauer wrote: Merge the two very similar functions sock_map_update_elem and sock_hash_update_elem into one. Signed-off-by: Lorenz Bauer Acked-by: Yonghong Song

Re: [PATCH bpf-next 2/6] bpf: sockmap: merge sockmap and sockhash update functions

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 10:24:32 +0100 Lorenz Bauer wrote: > --- a/net/core/sock_map.c > +++ b/net/core/sock_map.c > @@ -559,10 +559,12 @@ static bool sock_map_sk_state_allowed(const struct sock > *sk) > return false; > } > > -static int sock_map_update_elem(struct bpf_map *map, void *key, >