RE: [PATCH bpf-next 3/6] bpf: sockmap: call sock_map_update_elem directly

2020-08-19 Thread John Fastabend
Lorenz Bauer wrote: > Don't go via map->ops to call sock_map_update_elem, since we know > what function to call in bpf_map_update_value. Since > check_map_func_compatibility doesn't allow calling > BPF_FUNC_map_update_elem from BPF context, we can remove > ops->map_update_elem and rename the functi

Re: [PATCH bpf-next 3/6] bpf: sockmap: call sock_map_update_elem directly

2020-08-19 Thread Yonghong Song
On 8/19/20 2:24 AM, Lorenz Bauer wrote: Don't go via map->ops to call sock_map_update_elem, since we know what function to call in bpf_map_update_value. Since check_map_func_compatibility doesn't allow calling BPF_FUNC_map_update_elem from BPF context, we can remove ops->map_update_elem and re