Re: [PATCH char-misc] mei: bus: () can be static

2015-03-02 Thread Fengguang Wu
On Mon, Mar 02, 2015 at 12:41:05PM +0300, Dan Carpenter wrote: > On Mon, Mar 02, 2015 at 11:49:23AM +0800, kbuild test robot wrote: > > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not > > declared. Should it be static? > > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyper

RE: [PATCH char-misc] mei: bus: () can be static

2015-03-02 Thread Nick Meier
Yes - the function should have been static. This change correctly corrects the oversight. thanks, -Nick -Original Message- From: kbuild test robot [mailto:fengguang...@intel.com] Sent: Sunday, March 1, 2015 8:49 PM To: Tomas Winkler Cc: kbuild-...@01.org; Greg Kroah-Hartman; Nick Meie

RE: [PATCH char-misc] mei: bus: () can be static

2015-03-02 Thread Winkler, Tomas
inuxdriverproject.org > Subject: Re: [PATCH char-misc] mei: bus: () can be static > > On Mon, Mar 02, 2015 at 11:49:23AM +0800, kbuild test robot wrote: > > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not > declared. Should it be static

Re: [PATCH char-misc] mei: bus: () can be static

2015-03-02 Thread Dan Carpenter
On Mon, Mar 02, 2015 at 11:49:23AM +0800, kbuild test robot wrote: > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not > declared. Should it be static? > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not > declared. Should it be static? > drivers/hv/v