> From: netdev-ow...@vger.kernel.org <netdev-ow...@vger.kernel.org> On > Behalf Of Jason Yan > Sent: Thursday, May 7, 2020 4:09 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; da...@davemloft.net; > yanai...@huawei.com; intel-wired-...@lists.osuosl.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH net-next] igb: make igb_set_fc_watermarks() return void > > This function always return 0 now, we can make it return void to > simplify the code. This fixes the following coccicheck warning: > > drivers/net/ethernet/intel/igb/e1000_mac.c:728:5-12: Unneeded variable: > "ret_val". Return "0" on line 751 > > Signed-off-by: Jason Yan <yanai...@huawei.com> > --- > drivers/net/ethernet/intel/igb/e1000_mac.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > Tested-by: Aaron Brown <aaron.f.br...@intel.com>