RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-22 Thread Min Li
> ; Richard Cochran > Subject: Re: [PATCH net-next] misc: Add Renesas Synchronization > Management Unit (SMU) support > > On Thu, Feb 18, 2021 at 4:28 AM Min Li wrote: > > > If the driver can use the same algorithm that is in your user space > > > sof

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-18 Thread Min Li
> -Original Message- > From: Arnd Bergmann > Sent: February 18, 2021 5:51 AM > To: Min Li > Cc: Derek Kiernan ; Dragan Cvetic > ; Arnd Bergmann ; gregkh > ; linux-kernel@vger.kernel.org; Networking > ; Richard Cochran > Subject: Re: [PATCH net-next] misc:

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-18 Thread Arnd Bergmann
On Thu, Feb 18, 2021 at 4:28 AM Min Li wrote: > > If the driver can use the same algorithm that is in your user space software > > today, that would seem to be a nicer way to handle it than requiring a > > separate application. > > > > Hi Arnd > > > What is the device driver that you are

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Min Li
> -Original Message- > From: Arnd Bergmann > Sent: February 17, 2021 4:30 PM > To: Min Li > Cc: Derek Kiernan ; Dragan Cvetic > ; Arnd Bergmann ; gregkh > ; linux-kernel@vger.kernel.org; Networking > ; Richard Cochran > Subject: Re: [PATCH net-next] misc:

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Jakub Kicinski
On Wed, 17 Feb 2021 22:30:14 +0100 Arnd Bergmann wrote: > On Wed, Feb 17, 2021 at 9:20 PM Min Li wrote: > > I attached the G.8273.2 document, where chapter 6 is about supporting > > physical layer > > frequency. And combo mode is Renesas way to support this requirement. Other > > companies > >

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Arnd Bergmann
On Wed, Feb 17, 2021 at 9:20 PM Min Li wrote: > > I attached the G.8273.2 document, where chapter 6 is about supporting > physical layer > frequency. And combo mode is Renesas way to support this requirement. Other > companies > may come up with different ways to support it. > > When EEC

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Arnd Bergmann
On Tue, Feb 16, 2021 at 11:14 PM Min Li wrote: > > I can't help but think you are evading my question I asked. If there is no > > specific action that this pcm4l tool needs to perform, then I'd think we > > should better not provide any interface for it at all. > > > > I also found a reference to

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-16 Thread Min Li
> > I can't help but think you are evading my question I asked. If there is no > specific action that this pcm4l tool needs to perform, then I'd think we > should better not provide any interface for it at all. > > I also found a reference to only closed source software at >

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-16 Thread Arnd Bergmann
On Tue, Feb 16, 2021 at 6:10 PM Min Li wrote: > > > If I come up with a new file and move all the abstraction code there, > > > does that work? > > > > I think so, but it's more important to figure out a good user space > > interface > > first. The ioctl interfaces should be written on a

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-16 Thread Min Li
> > > > If I come up with a new file and move all the abstraction code there, > > does that work? > > I think so, but it's more important to figure out a good user space interface > first. The ioctl interfaces should be written on a higher-level abstraction, > to > ensure they can work with any

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Arnd Bergmann
On Fri, Feb 12, 2021 at 5:19 PM Min Li wrote: > > > > > Ah, so if this is for a PTP related driver, it should probably be > > integrated into > > the PTP subsystem rather than being a separate class. > > > > I was trying to add these functions to PHC subsystem but was not accepted > because the

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Min Li
> > Ah, so if this is for a PTP related driver, it should probably be integrated > into > the PTP subsystem rather than being a separate class. > I was trying to add these functions to PHC subsystem but was not accepted because the functions are specific to Renesas device and there is no

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Arnd Bergmann
On Fri, Feb 12, 2021 at 2:40 AM Min Li wrote: > > There should probably be a description of the purpose of the hardware both > > here and in the patch description. > > > > In particular, please explain how it relates to the existing clockmatrix > > driver. > > I just uploaded v2 patch to provide

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-11 Thread Arnd Bergmann
On Thu, Feb 11, 2021 at 4:03 AM wrote: > > From: Min Li > > This driver supports 1588 related functions of ClockMatrix(TM) > and 82P33xxx families of timing and synchronization devices. The > supported functons are: > > - set combomode > - get dpll's state > - get dpll's ffo > > Please note that

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-11 Thread Greg KH
On Wed, Feb 10, 2021 at 10:03:31PM -0500, min.li...@renesas.com wrote: > From: Min Li > > This driver supports 1588 related functions of ClockMatrix(TM) > and 82P33xxx families of timing and synchronization devices. The > supported functons are: > > - set combomode > - get dpll's state > - get

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 10:03:31PM -0500, min.li...@renesas.com wrote: > From: Min Li > > This driver supports 1588 related functions of ClockMatrix(TM) > and 82P33xxx families of timing and synchronization devices. The > supported functons are: > > - set combomode > - get dpll's state > - get

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-10 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/min-li-xe-renesas-com/misc-Add-Renesas-Synchronization-Management-Unit-SMU-support/20210211-113223 base: