David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, January 04, 2014 9:38 AM
> To: Hayeswang
> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-...@vger.kernel.org
> Subject: Re: [PATCH net-next] r8152: fix the wrong return value
>
> From: Hayes
David Miller [mailto:da...@davemloft.net]
Sent: Saturday, January 04, 2014 9:38 AM
To: Hayeswang
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-...@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: fix the wrong return value
From: Hayes Wang hayesw...@realtek.com
From: Hayes Wang
Date: Fri, 3 Jan 2014 11:21:56 +0800
> The return value should be the boolean value, not the error code.
>
> Signed-off-by: Hayes Wang
> Spotted-by: Dan Carpenter
Applied, but I agree with others that it's more canonical to have the
function return either an error code, or
From: Hayes Wang hayesw...@realtek.com
Date: Fri, 3 Jan 2014 11:21:56 +0800
The return value should be the boolean value, not the error code.
Signed-off-by: Hayes Wang hayesw...@realtek.com
Spotted-by: Dan Carpenter dan.carpen...@oracle.com
Applied, but I agree with others that it's more
On Fri, Jan 03, 2014 at 11:21:56AM +0800, Hayes Wang wrote:
> The return value should be the boolean value, not the error code.
>
> Signed-off-by: Hayes Wang
> Spotted-by: Dan Carpenter
> ---
> drivers/net/usb/r8152.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Fri, Jan 03, 2014 at 11:21:56AM +0800, Hayes Wang wrote:
The return value should be the boolean value, not the error code.
Signed-off-by: Hayes Wang hayesw...@realtek.com
Spotted-by: Dan Carpenter dan.carpen...@oracle.com
---
drivers/net/usb/r8152.c | 2 +-
1 file changed, 1
6 matches
Mail list logo
