RE: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

2020-11-17 Thread Hayes Wang
Jakub Kicinski > Sent: Wednesday, November 18, 2020 12:12 AM [...] > Something like this? > > config USB_RTL8153_ECM > tristate > select MII > select USB_NET_CDCETHER > depends on USB_RTL8152 || USB_RTL8152=n > help > > > > select clauses will pull

Re: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 01:50:03 + Hayes Wang wrote: > Jakub Kicinski > > Sent: Tuesday, November 17, 2020 1:03 AM > [...] > > > Yes, this fixes this issue, although I would prefer a separate Kconfig > > > entry for r8153_ecm with proper dependencies instead of this ifdefs in > > > Makefile. >

RE: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

2020-11-16 Thread Hayes Wang
Jakub Kicinski > Sent: Tuesday, November 17, 2020 1:03 AM [...] > > Yes, this fixes this issue, although I would prefer a separate Kconfig > > entry for r8153_ecm with proper dependencies instead of this ifdefs in > > Makefile. > > Agreed, this is what dependency resolution is for. > > Let's jus

Re: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 10:18:13 +0100 Marek Szyprowski wrote: > On 16.11.2020 07:52, Hayes Wang wrote: > > Avoid r8153_ecm is compiled as built-in, if r8152 driver is compiled > > as modules. Otherwise, the r8153_ecm would be used, even though the > > device is supported by r8152 driver. > > > > Fixes

Re: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

2020-11-16 Thread Marek Szyprowski
Hi On 16.11.2020 07:52, Hayes Wang wrote: > Avoid r8153_ecm is compiled as built-in, if r8152 driver is compiled > as modules. Otherwise, the r8153_ecm would be used, even though the > device is supported by r8152 driver. > > Fixes: c1aedf015ebd ("net/usb/r8153_ecm: support ECM mode for RTL8153")