RE: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-23 Thread Jose Abreu
From: Ondřej Jirman Date: Jul/22/2019, 15:39:55 (UTC+00:00) > On Mon, Jul 22, 2019 at 02:26:45PM +, Jose Abreu wrote: > > From: Andrew Lunn > > Date: Jul/22/2019, 15:19:43 (UTC+00:00) > > > > > On Mon, Jul 22, 2019 at 01:58:20PM +, Jose Abreu wrote: > > > > From: Andrew Lunn > > > >

Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-22 Thread Ondřej Jirman
On Mon, Jul 22, 2019 at 02:26:45PM +, Jose Abreu wrote: > From: Andrew Lunn > Date: Jul/22/2019, 15:19:43 (UTC+00:00) > > > On Mon, Jul 22, 2019 at 01:58:20PM +, Jose Abreu wrote: > > > From: Andrew Lunn > > > Date: Jul/22/2019, 14:40:23 (UTC+00:00) > > > > > > > Does this mean that

RE: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-22 Thread Jose Abreu
From: Andrew Lunn Date: Jul/22/2019, 15:19:43 (UTC+00:00) > On Mon, Jul 22, 2019 at 01:58:20PM +, Jose Abreu wrote: > > From: Andrew Lunn > > Date: Jul/22/2019, 14:40:23 (UTC+00:00) > > > > > Does this mean that all stmmac variants support 1G? There are none > > > which just support Fast

Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-22 Thread Andrew Lunn
On Mon, Jul 22, 2019 at 01:58:20PM +, Jose Abreu wrote: > From: Andrew Lunn > Date: Jul/22/2019, 14:40:23 (UTC+00:00) > > > Does this mean that all stmmac variants support 1G? There are none > > which just support Fast Ethernet? > > This glue logic drivers sometimes reflect a custom IP

RE: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-22 Thread Jose Abreu
From: Andrew Lunn Date: Jul/22/2019, 14:40:23 (UTC+00:00) > Does this mean that all stmmac variants support 1G? There are none > which just support Fast Ethernet? This glue logic drivers sometimes reflect a custom IP that's Synopsys based but modified by customer, so I can't know before-hand

Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-22 Thread Ondřej Jirman
On Mon, Jul 22, 2019 at 01:28:51PM +, Jose Abreu wrote: > From: Ondřej Jirman > Date: Jul/22/2019, 13:42:40 (UTC+00:00) > > > Hello Jose, > > > > On Tue, Jun 11, 2019 at 05:18:44PM +0200, Jose Abreu wrote: > > > [ Hope this diff looks better (generated with --minimal) ] > > > > > > This

Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-22 Thread Andrew Lunn
On Mon, Jul 22, 2019 at 01:28:51PM +, Jose Abreu wrote: > From: Ondřej Jirman > Date: Jul/22/2019, 13:42:40 (UTC+00:00) > > > Hello Jose, > > > > On Tue, Jun 11, 2019 at 05:18:44PM +0200, Jose Abreu wrote: > > > [ Hope this diff looks better (generated with --minimal) ] > > > > > > This

RE: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-22 Thread Jose Abreu
From: Ondřej Jirman Date: Jul/22/2019, 13:42:40 (UTC+00:00) > Hello Jose, > > On Tue, Jun 11, 2019 at 05:18:44PM +0200, Jose Abreu wrote: > > [ Hope this diff looks better (generated with --minimal) ] > > > > This converts stmmac to use phylink. Besides the code redution this will > > allow to

Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-07-22 Thread Ondřej Jirman
Hello Jose, On Tue, Jun 11, 2019 at 05:18:44PM +0200, Jose Abreu wrote: > [ Hope this diff looks better (generated with --minimal) ] > > This converts stmmac to use phylink. Besides the code redution this will > allow to gain more flexibility. I'm testing 5.3-rc1 and on Orange Pi 3 (uses

RE: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-06-14 Thread Jose Abreu
From: Corentin Labbe > since this patch I hit > dwmac-sun8i 1c3.ethernet: ethernet@1c3 PHY address 29556736 is too > large > > any idea ? This is because phy_node is no longer pointing to the same place so sun8i_dwmac_set_syscon() fails. I'm seeing this pattern of using phy_node in

Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-06-14 Thread Corentin Labbe
On Tue, Jun 11, 2019 at 05:18:44PM +0200, Jose Abreu wrote: > [ Hope this diff looks better (generated with --minimal) ] > > This converts stmmac to use phylink. Besides the code redution this will > allow to gain more flexibility. > > Cc: Joao Pinto > Cc: David S. Miller > Cc: Giuseppe

Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink

2019-06-13 Thread David Miller
From: Jose Abreu Date: Tue, 11 Jun 2019 17:18:44 +0200 > [ Hope this diff looks better (generated with --minimal) ] > > This converts stmmac to use phylink. Besides the code redution this will > allow to gain more flexibility. Series applied, thank you.