Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-24 Thread Valdis . Kletnieks
On Thu, 24 Jul 2014 16:58:23 -0700, Alexei Starovoitov said: > On Thu, Jul 24, 2014 at 4:45 PM, wrote: > > On Tue, 22 Jul 2014 23:01:58 -0700, Alexei Starovoitov said: > >> +obj-$(CONFIG_NET) += bpf/ > > > > I was expecting to see CONFIG_NETFILTER here. Is CONFIG_NET intentional? > > yes. it

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-24 Thread Alexei Starovoitov
On Thu, Jul 24, 2014 at 4:45 PM, wrote: > On Tue, 22 Jul 2014 23:01:58 -0700, Alexei Starovoitov said: >> BPF is used in several kernel components. This split creates logical boundary >> between generic eBPF core and the rest >> >> kernel/bpf/core.c: eBPF interpreter >> >> net/core/filter.c:

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-24 Thread Valdis . Kletnieks
On Tue, 22 Jul 2014 23:01:58 -0700, Alexei Starovoitov said: > BPF is used in several kernel components. This split creates logical boundary > between generic eBPF core and the rest > > kernel/bpf/core.c: eBPF interpreter > > net/core/filter.c: classic->eBPF converter, classic verifiers, socket

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-24 Thread Valdis . Kletnieks
On Tue, 22 Jul 2014 23:01:58 -0700, Alexei Starovoitov said: BPF is used in several kernel components. This split creates logical boundary between generic eBPF core and the rest kernel/bpf/core.c: eBPF interpreter net/core/filter.c: classic-eBPF converter, classic verifiers, socket filters

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-24 Thread Alexei Starovoitov
On Thu, Jul 24, 2014 at 4:45 PM, valdis.kletni...@vt.edu wrote: On Tue, 22 Jul 2014 23:01:58 -0700, Alexei Starovoitov said: BPF is used in several kernel components. This split creates logical boundary between generic eBPF core and the rest kernel/bpf/core.c: eBPF interpreter

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-24 Thread Valdis . Kletnieks
On Thu, 24 Jul 2014 16:58:23 -0700, Alexei Starovoitov said: On Thu, Jul 24, 2014 at 4:45 PM, valdis.kletni...@vt.edu wrote: On Tue, 22 Jul 2014 23:01:58 -0700, Alexei Starovoitov said: +obj-$(CONFIG_NET) += bpf/ I was expecting to see CONFIG_NETFILTER here. Is CONFIG_NET intentional?

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread Alexei Starovoitov
On Wed, Jul 23, 2014 at 10:54:04AM +0200, Daniel Borkmann wrote: > On 07/23/2014 08:11 AM, Varka Bhadram wrote: > >On 07/23/2014 11:31 AM, Alexei Starovoitov wrote: > >>BPF is used in several kernel components. This split creates logical > >>boundary > >>between generic eBPF core and the rest >

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread Daniel Borkmann
On 07/23/2014 08:11 AM, Varka Bhadram wrote: On 07/23/2014 11:31 AM, Alexei Starovoitov wrote: BPF is used in several kernel components. This split creates logical boundary between generic eBPF core and the rest kernel/bpf/core.c: eBPF interpreter net/core/filter.c: classic->eBPF converter,

RE: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread David Laight
From: Varka Bhadram > On 07/23/2014 11:31 AM, Alexei Starovoitov wrote: > > BPF is used in several kernel components. This split creates logical > > boundary > > between generic eBPF core and the rest > > > > kernel/bpf/core.c: eBPF interpreter > > > > net/core/filter.c: classic->eBPF converter,

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread Varka Bhadram
On 07/23/2014 11:31 AM, Alexei Starovoitov wrote: BPF is used in several kernel components. This split creates logical boundary between generic eBPF core and the rest kernel/bpf/core.c: eBPF interpreter net/core/filter.c: classic->eBPF converter, classic verifiers, socket filters This patch

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread Varka Bhadram
On 07/23/2014 11:31 AM, Alexei Starovoitov wrote: BPF is used in several kernel components. This split creates logical boundary between generic eBPF core and the rest kernel/bpf/core.c: eBPF interpreter net/core/filter.c: classic-eBPF converter, classic verifiers, socket filters This patch

RE: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread David Laight
From: Varka Bhadram On 07/23/2014 11:31 AM, Alexei Starovoitov wrote: BPF is used in several kernel components. This split creates logical boundary between generic eBPF core and the rest kernel/bpf/core.c: eBPF interpreter net/core/filter.c: classic-eBPF converter, classic

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread Daniel Borkmann
On 07/23/2014 08:11 AM, Varka Bhadram wrote: On 07/23/2014 11:31 AM, Alexei Starovoitov wrote: BPF is used in several kernel components. This split creates logical boundary between generic eBPF core and the rest kernel/bpf/core.c: eBPF interpreter net/core/filter.c: classic-eBPF converter,

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread Alexei Starovoitov
On Wed, Jul 23, 2014 at 10:54:04AM +0200, Daniel Borkmann wrote: On 07/23/2014 08:11 AM, Varka Bhadram wrote: On 07/23/2014 11:31 AM, Alexei Starovoitov wrote: BPF is used in several kernel components. This split creates logical boundary between generic eBPF core and the rest