hayeswang :
> Francois Romieu [mailto:rom...@fr.zoreil.com]
> [...]
> > It would be nice to state these things in the commit message, namely:
> > - ALDPS should never be enabled for the RTL8105e
> > - none of the firmware-free chipsets support ALDPS
> > - neither do the RTL8168d/8111d
>
>
hayeswang hayesw...@realtek.com :
Francois Romieu [mailto:rom...@fr.zoreil.com]
[...]
It would be nice to state these things in the commit message, namely:
- ALDPS should never be enabled for the RTL8105e
- none of the firmware-free chipsets support ALDPS
- neither do the
Francois Romieu [mailto:rom...@fr.zoreil.com]
[...]
> It would be nice to state these things in the commit message, namely:
> - ALDPS should never be enabled for the RTL8105e
> - none of the firmware-free chipsets support ALDPS
> - neither do the RTL8168d/8111d
Excuse me. I don't understand why
hayeswang :
[...]
> The flag is determined if the firmware is loaded. It doesn't mean to enable
> ALDPS. Besides ALDPS, the firmware includes the other features about power
> saving, performance, hw behavior, and so on. Thus, I think it is the extended
> feature. Any suggestion?
hayeswang hayesw...@realtek.com :
[...]
The flag is determined if the firmware is loaded. It doesn't mean to enable
ALDPS. Besides ALDPS, the firmware includes the other features about power
saving, performance, hw behavior, and so on. Thus, I think it is the extended
feature. Any suggestion?
Francois Romieu [mailto:rom...@fr.zoreil.com]
[...]
It would be nice to state these things in the commit message, namely:
- ALDPS should never be enabled for the RTL8105e
- none of the firmware-free chipsets support ALDPS
- neither do the RTL8168d/8111d
Excuse me. I don't understand why the
Francois Romieu [mailto:rom...@fr.zoreil.com]
> Sent: Tuesday, October 23, 2012 3:28 AM
> To: Hayeswang
> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org;
> j...@google.com
> Subject: Re: [PATCH net-next 1/2] r8169: enable ALDPS for power saving
>
[...]
> >
Hayes Wang :
> Enable ALDPS function to save power when link down. Note that the
> feature should be set after the other PHY settings. And the firmware
> is necessary. Don't enable it without loading the firmware.
>
> Signed-off-by: Hayes Wang
> ---
> drivers/net/ethernet/realtek/r8169.c | 46
From: Hayes Wang
Date: Mon, 22 Oct 2012 16:05:53 +0800
> Enable ALDPS function to save power when link down. Note that the
> feature should be set after the other PHY settings. And the firmware
> is necessary. Don't enable it without loading the firmware.
>
> Signed-off-by: Hayes Wang
If
From: Hayes Wang hayesw...@realtek.com
Date: Mon, 22 Oct 2012 16:05:53 +0800
Enable ALDPS function to save power when link down. Note that the
feature should be set after the other PHY settings. And the firmware
is necessary. Don't enable it without loading the firmware.
Signed-off-by:
Hayes Wang hayesw...@realtek.com :
Enable ALDPS function to save power when link down. Note that the
feature should be set after the other PHY settings. And the firmware
is necessary. Don't enable it without loading the firmware.
Signed-off-by: Hayes Wang hayesw...@realtek.com
---
Francois Romieu [mailto:rom...@fr.zoreil.com]
Sent: Tuesday, October 23, 2012 3:28 AM
To: Hayeswang
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org;
j...@google.com
Subject: Re: [PATCH net-next 1/2] r8169: enable ALDPS for power saving
[...]
@@ -687,6 +687,7 @@ enum features
12 matches
Mail list logo
