Re: [PATCH net-next 1/3] r8152: separate USB_RX_EARLY_AGG

Hello. On 2/12/2015 5:36 AM, Hayes Wang wrote: [...] + ocp_data = tp->coalesce / 8; Why not do it in the initializer? This is for patch #3. The patch #3 would use this function. The new function is already called in this patch. The unit of the relative setting from the

RE: [PATCH net-next 1/3] r8152: separate USB_RX_EARLY_AGG

Sergei Shtylyov; net...@vger.kernel.org [...] > > > + ocp_data = tp->coalesce / 8; > > > > Why not do it in the initializer? > > This is for patch #3. The patch #3 would use this function. > The unit of the relative setting from the ethtool is 1 us. > However, the unit for the hw is 8 us. Ther

RE: [PATCH net-next 1/3] r8152: separate USB_RX_EARLY_AGG

Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] [...] > > + ocp_data = tp->coalesce / 8; > > Why not do it in the initializer? This is for patch #3. The patch #3 would use this function. The unit of the relative setting from the ethtool is 1 us. However, the unit for the hw is

Re: [PATCH net-next 1/3] r8152: separate USB_RX_EARLY_AGG

Hello. On 2/11/2015 9:46 AM, Hayes Wang wrote: Separate USB_RX_EARLY_AGG into USB_RX_EARLY_TIMEOUT and USB_RX_EARLY_SIZE. Replace r8153_set_rx_agg() with r8153_set_rx_early_timeout() and r8153_set_rx_early_size(). Set the default timeout value according to the USB speed. Signed-off-by: