David Miller [mailto:da...@davemloft.net]
> Sent: Friday, November 14, 2014 5:23 AM
[...]
> What if even the first r8152_submit_rx() fails? What ever will cause
> any of these retries to trigger at all?
According to the patch #1 "adjust r8152_submit_rx", the
r8152_submit_rx() would add the rx to
From: David Miller
Date: Wed, 12 Nov 2014 22:31:46 -0500 (EST)
> From: Hayes Wang
> Date: Thu, 13 Nov 2014 02:31:14 +
>
>> My last method which I mentioned yesterday is similar to
>> this one. The difference is that I would re-use the rx
>> buffers, so I have to add them to the list for re-
From: Hayes Wang
Date: Thu, 13 Nov 2014 02:31:14 +
> My last method which I mentioned yesterday is similar to
> this one. The difference is that I would re-use the rx
> buffers, so I have to add them to the list for re-submitting,
> not alwayes allocate new one.
>
> Although one rx buffer co
David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, November 13, 2014 3:50 AM
[...]
> > According to the usbnet.c, it would make sure to submit the
> > number of min(10, RX_QLEN(dev)) rx buffers. If there are
> > not enough rx buffers, it schedule a tasklet for next try.
> >
> > The brief
From: Hayes Wang
Date: Wed, 12 Nov 2014 06:29:46 +
> David Miller [mailto:da...@davemloft.net]
>> Sent: Wednesday, November 12, 2014 1:44 PM
> [...]
>> What do other USB network drivers do in similar situations?
>
> According to the usbnet.c, it would make sure to submit the
> number of min
David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, November 12, 2014 1:44 PM
[...]
> What do other USB network drivers do in similar situations?
According to the usbnet.c, it would make sure to submit the
number of min(10, RX_QLEN(dev)) rx buffers. If there are
not enough rx buffers, it
From: Hayes Wang
Date: Wed, 12 Nov 2014 05:23:03 +
> David Miller [mailto:da...@davemloft.net]
>> Sent: Wednesday, November 12, 2014 1:13 PM
> [...]
>> I really want to know why you are spending so much effort on this.
>>
>> Is there a real situation that happened very often, which you
>> d
David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, November 12, 2014 1:13 PM
[...]
> I really want to know why you are spending so much effort on this.
>
> Is there a real situation that happened very often, which you
> diagnosed in detail, and therefore you want to address?
No. I just
From: Hayes Wang
Date: Wed, 12 Nov 2014 05:07:40 +
> How about that when a error occurs, add the remaining rx
> to the list without submission? Then, the remianing rx
> could be re-submitted later, and the rtl_start_rx() could
> be completed as soon as possible.
I really want to know why you
David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, November 12, 2014 10:51 AM
[...]
> Ok, but if we are looping here in rtl_start_rx() and r8152_submit_rx()
> fails due to a memory allocation failure, there is nothing which is
> going to make such a memory allocation succeed in the next
From: Hayes Wang
Date: Mon, 10 Nov 2014 03:29:27 +
> The behavior is different for PCI(e) and USB ethernet device.
> The PCI nic could know the ring buffer by certain way, so
> the device could fill the data into the buffer one by one
> automatically. However, for usb nic, the driver has to
>
David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, November 08, 2014 12:35 AM
[...]
> Does this even work?
>
> If you leave a hole in the ring, the device is going to stop there
> anyways.
>
> So better to replenish the next time you call into this function
> rather than leaving gaps in
David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, November 12, 2014 10:20 AM
[...]
> I haven't had time to process your original reply, please be patient.
I am sorry for bothering you, and thanks for your reply.
Best Regards,
Hayes
--
To unsubscribe from this list: send the line "uns
From: Hayes Wang
Date: Wed, 12 Nov 2014 01:45:08 +
> David Miller [mailto:da...@davemloft.net]
>> Sent: Saturday, November 08, 2014 12:35 AM
> [...]
>> Does this even work?
>>
>> If you leave a hole in the ring, the device is going to stop there
>> anyways.
>>
>> So better to replenish the
David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, November 08, 2014 12:35 AM
[...]
> Does this even work?
>
> If you leave a hole in the ring, the device is going to stop there
> anyways.
Excuse me. I don't sure I understand your meaning clearly.
The behavior is different for PCI(e)
From: Hayes Wang
Date: Fri, 7 Nov 2014 17:55:11 +0800
> Submit all the rx buffers, even though a error occurs. Otherwise
> the buffers which are not submitted would be lost until next
> rtl_start_rx() is called. Besides, the fail buffer could be
> re-submitted later.
>
> Signed-off-by: Hayes Wan
16 matches
Mail list logo
