RE: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-21 Thread Hayes Wang
Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] [...] > >> Why leave 2 empty lines? One is enough. > > > The next patch would use another fucntion at the > > same location. I skip removing the empty line and > > re-adding it again. Is that better to do so? I would > > resend the

Re: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-21 Thread Sergei Shtylyov
On 08/21/2014 06:12 AM, Hayes Wang wrote: [...] r8152b_disable_aldps(tp); - rtl_clear_bp(tp); Why leave 2 empty lines? One is enough. The next patch would use another fucntion at the same location. I skip removing the empty line and re-adding it again. Is that better

RE: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-20 Thread Hayes Wang
: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Wednesday, August 20, 2014 8:01 PM > To: Hayes Wang; net...@vger.kernel.org > Cc: nic_swsd; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org > Subject: Re: [PATCH net-next 3/4] r8152: remove clear

Re: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-20 Thread Sergei Shtylyov
Hello. On 8/20/2014 12:58 PM, Hayes Wang wrote: The functions are used to update the firmware. Move the actions into the firmware files. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/net/usb/r8