RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

ger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 > Ethernet driver for hip08 SoC > > > Since I would be touching the core, lots of drivers will get impacted > and will > > have to wait till ever

RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

ger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 > Ethernet driver for hip08 SoC > > > Since I would be touching the core, lots of drivers will get impacted > and will > > have to wait till ever

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

> Since I would be touching the core, lots of drivers will get impacted and will > have to wait till everyone gives clean signal. This will impact our internal > deadlines. But as I said I am eager to cooperate & contribute :) Just as an FYI. Your internal deadlines are irrelevant. We will

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

> Since I would be touching the core, lots of drivers will get impacted and will > have to wait till everyone gives clean signal. This will impact our internal > deadlines. But as I said I am eager to cooperate & contribute :) Just as an FYI. Your internal deadlines are irrelevant. We will

RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

ger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 > Ethernet driver for hip08 SoC > > > > Hum why do you do this? mdiobus_register() will scan through your > bus > > > provided that y

RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

ger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 > Ethernet driver for hip08 SoC > > > > Hum why do you do this? mdiobus_register() will scan through your > bus > > > provided that y

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

> > Hum why do you do this? mdiobus_register() will scan through your bus > > provided that you set an appropriate phy_mask value (here you tell it > > not to) and you already provide the PHY address to scan for > > > I know this looks weird but the reason why it appears as it is in code is: > >

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

> > Hum why do you do this? mdiobus_register() will scan through your bus > > provided that you set an appropriate phy_mask value (here you tell it > > not to) and you already provide the PHY address to scan for > > > I know this looks weird but the reason why it appears as it is in code is: > >

RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

.org; linux- > ker...@vger.kernel.org; Linuxarm; Andrew Lunn > Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 > Ethernet driver for hip08 SoC > > Le 06/09/17 à 20:46, Salil Mehta a écrit : > > This patch adds the support of MDIO bus interface for HNS3 drive

RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

.org; linux- > ker...@vger.kernel.org; Linuxarm; Andrew Lunn > Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 > Ethernet driver for hip08 SoC > > Le 06/09/17 à 20:46, Salil Mehta a écrit : > > This patch adds the support of MDIO bus interface for HNS3 drive

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

> You are correct is_c45 should not be derived from the type of PHY like > it is being done here. I have changed this code and now we are getting this > information from the IMP(Integrated Management Processor) which handles > the NIC commands and also maintains Ethernet specific configuration.

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

> You are correct is_c45 should not be derived from the type of PHY like > it is being done here. I have changed this code and now we are getting this > information from the IMP(Integrated Management Processor) which handles > the NIC commands and also maintains Ethernet specific configuration.

RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 > Ethernet driver for hip08 SoC > > > > +int hclge_mac_mdio_config(struct hclge_dev *hdev) > > > +{ > > > + struct hclge_mac *mac =

RE: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 > Ethernet driver for hip08 SoC > > > > +int hclge_mac_mdio_config(struct hclge_dev *hdev) > > > +{ > > > + struct hclge_mac *mac =

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

> > +int hclge_mac_mdio_config(struct hclge_dev *hdev) > > +{ > > + struct hclge_mac *mac = >hw.mac; > > + struct mii_bus *mdio_bus; > > + struct net_device *ndev = >ndev; > > + struct phy_device *phy; > > + bool is_c45; > > + int ret; > > + > > + if (hdev->hw.mac.phy_addr >=

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

> > +int hclge_mac_mdio_config(struct hclge_dev *hdev) > > +{ > > + struct hclge_mac *mac = >hw.mac; > > + struct mii_bus *mdio_bus; > > + struct net_device *ndev = >ndev; > > + struct phy_device *phy; > > + bool is_c45; > > + int ret; > > + > > + if (hdev->hw.mac.phy_addr >=

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

Le 06/09/17 à 20:46, Salil Mehta a écrit : > This patch adds the support of MDIO bus interface for HNS3 driver. > Code provides various interfaces to start and stop the PHY layer > and to read and write the MDIO bus or PHY. > > Signed-off-by: Daode Huang >

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

Le 06/09/17 à 20:46, Salil Mehta a écrit : > This patch adds the support of MDIO bus interface for HNS3 driver. > Code provides various interfaces to start and stop the PHY layer > and to read and write the MDIO bus or PHY. > > Signed-off-by: Daode Huang > Signed-off-by: lipeng > Signed-off-by: