RE: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool

2019-07-09 Thread Jose Abreu
From: Ilias Apalodimas | Date: Tue, Jul 09, 2019 at 08:23:56 > The patch from Ivan did get merged, can you change the free call to > page_pool_destroy and re-spin? You can add my acked-by Yes, I will re-spin then. Thanks! --- Thanks, Jose Miguel Abreu

Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool

2019-07-09 Thread Ilias Apalodimas
Hello, > From: Jose Abreu > Date: Mon, 8 Jul 2019 16:08:07 + > > > From: Ilias Apalodimas | Date: Fri, Jul > > 05, 2019 at 16:24:53 > > > >> Well ideally we'd like to get the change in before the merge window > >> ourselves, > >> since we dont want to remove->re-add the same function

Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool

2019-07-08 Thread David Miller
From: Jose Abreu Date: Mon, 8 Jul 2019 16:08:07 + > From: Ilias Apalodimas | Date: Fri, Jul > 05, 2019 at 16:24:53 > >> Well ideally we'd like to get the change in before the merge window >> ourselves, >> since we dont want to remove->re-add the same function in stable kernels. If >>

RE: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool

2019-07-08 Thread Jose Abreu
From: Ilias Apalodimas | Date: Fri, Jul 05, 2019 at 16:24:53 > Well ideally we'd like to get the change in before the merge window ourselves, > since we dont want to remove->re-add the same function in stable kernels. If > that doesn't go in i am fine fixing it in the next merge window i guess,

Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool

2019-07-05 Thread Ilias Apalodimas
Hi Jose, On Fri, Jul 05, 2019 at 03:21:16PM +, Jose Abreu wrote: > From: Ilias Apalodimas > > > I think this look ok for now. One request though, on page_pool_free > > Thanks for the review! > > > A patch currently under review will slightly change that [1] and [2] > > Can you defer

RE: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool

2019-07-05 Thread Jose Abreu
From: Ilias Apalodimas > I think this look ok for now. One request though, on page_pool_free Thanks for the review! > A patch currently under review will slightly change that [1] and [2] > Can you defer this a bit till that one gets merged? > The only thing you'll have to do is respin this

Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool

2019-07-05 Thread Ilias Apalodimas
Hi Jose, I think this look ok for now. One request though, on page_pool_free On Fri, Jul 05, 2019 at 09:23:00AM +0200, Jose Abreu wrote: > Mapping and unmapping DMA region is an high bottleneck in stmmac driver, > specially in the RX path. > > This commit introduces support for Page Pool API