Re: [PATCH net-next v5] cadence: Add LSO support.

2016-11-15 Thread David Miller
From: Rafal Ozieblo Date: Tue, 15 Nov 2016 07:07:14 + > Would it be good to enable UFO conditionally with some internal > define? Ex.: Absolutely not.

RE: [PATCH net-next v5] cadence: Add LSO support.

2016-11-15 Thread Rafal Ozieblo
> From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: 15 listopada 2016 14:12 > To: Rafal Ozieblo > Cc: David Miller; nicolas.fe...@atmel.com; net...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next v5] cadence: Add LSO support. > >

Re: [PATCH net-next v5] cadence: Add LSO support.

2016-11-15 Thread Eric Dumazet
On Tue, 2016-11-15 at 07:07 +, Rafal Ozieblo wrote: > > > > If UFO is in use it should not silently disable UDP checksums. > > > > > > > > If you cannot support UFO with proper checksumming, then you cannot > > > > enable support for that feature. > > > > > > According Cadence Gigabit Ethern

RE: [PATCH net-next v5] cadence: Add LSO support.

2016-11-14 Thread Rafal Ozieblo
> > > If UFO is in use it should not silently disable UDP checksums. > > > > > > If you cannot support UFO with proper checksumming, then you cannot > > > enable support for that feature. > > > > According Cadence Gigabit Ethernet MAC documentation: > > > > "Hardware will not calculate the UDP

Re: [PATCH net-next v5] cadence: Add LSO support.

2016-11-14 Thread David Miller
From: Rafal Ozieblo Date: Mon, 14 Nov 2016 09:32:34 + >> If UFO is in use it should not silently disable UDP checksums. >> >> If you cannot support UFO with proper checksumming, then you cannot enable >> support for that feature. > > According Cadence Gigabit Ethernet MAC documentation: >

Re: [PATCH net-next v5] cadence: Add LSO support.

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 09:32 +, Rafal Ozieblo wrote: > From: David Miller [mailto:da...@davemloft.net] > Sent: 10 listopada 2016 18:01 > To: Rafal Ozieblo > Cc: nicolas.fe...@atmel.com; net...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next v5]

RE: [PATCH net-next v5] cadence: Add LSO support.

2016-11-14 Thread Rafal Ozieblo
From: David Miller [mailto:da...@davemloft.net] Sent: 10 listopada 2016 18:01 To: Rafal Ozieblo Cc: nicolas.fe...@atmel.com; net...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5]] cadence: Add LSO support. From: Rafal Ozieblo Date: Wed, 9 Nov 2016 13:41:02 +

Re: [PATCH net-next v5]] cadence: Add LSO support.

2016-11-10 Thread David Miller
From: Rafal Ozieblo Date: Wed, 9 Nov 2016 13:41:02 + First, please remove the spurious closing bracket in your Subject line in future submittions. > + if (is_udp) /* is_udp is only set when (is_lso) is checked */ > + /* zero UDP checksum, not calculated by h/w for UFO */ > +