Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-05 Thread Alan Stern
On Thu, 5 Jun 2014, Andrzej Pietrasiewicz wrote: > I think it is easier to tell the purpose of the two structures taking > gadgets composed with configfs as example. > > In each gadget there is "functions" directory. Function directories > are created there: > > $ cd $CONFIGFS_ROOT/usb_gadget/ou

RE: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-05 Thread Alan Stern
On Thu, 5 Jun 2014, Peter Chen wrote: > > > > It is a little strange we call gadget's disconnect at SET_ADDRESS? > > > > How the udc calls gadget driver the disconnection has happened when > > > > the usb cable is disconnected from the host? > > > > > > > > Usually, we call gadget's disconnect at

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-05 Thread Andrzej Pietrasiewicz
W dniu 04.06.2014 17:26, Alan Stern pisze: On Wed, 4 Jun 2014, Andrzej Pietrasiewicz wrote: What is the difference in purpose between usb_function and usb_function_instance? I can't tell just by reading the header file. Does one of them get created dynamically when the host sets the approp

RE: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-04 Thread Peter Chen
> On Wed, 4 Jun 2014, Yang,Wei wrote: > > > On 06/04/2014 09:45 AM, Peter Chen wrote: > > > > > >> commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791 > > >> Author: Robert Baldyga > > >> Date: Thu Nov 21 13:49:18 2013 +0100 > > >> > > >> usb: gadget: s3c-hsotg: fix disconnect handling > >

RE: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-04 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern > Sent: Wednesday, June 04, 2014 6:57 AM > > On Wed, 4 Jun 2014, Yang,Wei wrote: > > > On 06/04/2014 09:45 AM, Peter Chen wrote: > > > > > >> commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-04 Thread Alan Stern
On Wed, 4 Jun 2014, Andrzej Pietrasiewicz wrote: > When Sebastian introduced the function registration interface I didn't > specially like the naming: struct usb_function_instance is something > different than an instance of struct usb_function. What is the difference in purpose between usb_funct

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-04 Thread Alan Stern
On Wed, 4 Jun 2014, Yang,Wei wrote: > On 06/04/2014 09:45 AM, Peter Chen wrote: > > > >> commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791 > >> Author: Robert Baldyga > >> Date: Thu Nov 21 13:49:18 2013 +0100 > >> > >> usb: gadget: s3c-hsotg: fix disconnect handling > >> > >> This

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-04 Thread Andrzej Pietrasiewicz
Hi Alan, W dniu 03.06.2014 16:48, Alan Stern pisze: On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. In fact, it is more easy to reproduce it with RT kernel. WARNING: at drivers/usb/gadget/composite.c: u

RE: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Peter Chen
> On 06/04/2014 09:45 AM, Peter Chen wrote: > > > >> commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791 > >> Author: Robert Baldyga > >> Date: Thu Nov 21 13:49:18 2013 +0100 > >> > >> usb: gadget: s3c-hsotg: fix disconnect handling > >> > >> This patch moves s3c_hsotg_disconnect funct

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
On 06/04/2014 09:45 AM, Peter Chen wrote: commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791 Author: Robert Baldyga Date: Thu Nov 21 13:49:18 2013 +0100 usb: gadget: s3c-hsotg: fix disconnect handling This patch moves s3c_hsotg_disconnect function call from USBSusp interrupt

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
Guys, It seems the previous description is out of order. I describe it again. Sorry for it. irq handler | |-> s3c_hsotg_disconnect() | |-> common->new_fsg = NULL |-> common->state = FSG_STATE_CONFIG |-> wakes up fsg_main_thread. |->set USB device address. fsg_ma

RE: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Peter Chen
> > commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791 > Author: Robert Baldyga > Date: Thu Nov 21 13:49:18 2013 +0100 > > usb: gadget: s3c-hsotg: fix disconnect handling > > This patch moves s3c_hsotg_disconnect function call from USBSusp > interrupt > handler to SET_ADDRESS re

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
On 06/03/2014 10:48 PM, Alan Stern wrote: On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. In fact, it is more easy to reproduce it with RT kernel. WARNING: at drivers/usb/gadget/composite.c: usb_composit

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Alan Stern
On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: > From: Yang Wei > > While loading g_mass_storage module, the following warning is triggered. > In fact, it is more easy to reproduce it with RT kernel. > > WARNING: at drivers/usb/gadget/composite.c: > usb_composite_setup_continue: Unexpected ca