Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Brendan Higgins
On Tue, Aug 27, 2019 at 3:55 PM shuah wrote: > > On 8/27/19 4:16 PM, Brendan Higgins wrote: > > On Tue, Aug 27, 2019 at 3:00 PM shuah wrote: > >> > >> On 8/27/19 3:36 PM, Brendan Higgins wrote: > >>> On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins > >>> wrote: > > On Tue, Aug 27, 2019

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread shuah
On 8/27/19 4:16 PM, Brendan Higgins wrote: On Tue, Aug 27, 2019 at 3:00 PM shuah wrote: On 8/27/19 3:36 PM, Brendan Higgins wrote: On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins wrote: On Tue, Aug 27, 2019 at 2:03 PM Brendan Higgins wrote: On Tue, Aug 27, 2019 at 1:21 PM shuah wrote:

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Brendan Higgins
On Tue, Aug 27, 2019 at 3:38 PM wrote: > > > > > -Original Message- > > From: Brendan Higgins > > > > On Tue, Aug 27, 2019 at 3:00 PM shuah wrote: > > > > > > On 8/27/19 3:36 PM, Brendan Higgins wrote: > > > > On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins > > > > wrote: > > > >> > > >

RE: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > On Tue, Aug 27, 2019 at 3:00 PM shuah wrote: > > > > On 8/27/19 3:36 PM, Brendan Higgins wrote: > > > On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins > > > wrote: > > >> > > >> On Tue, Aug 27, 2019 at 2:03 PM Brendan Higgins > > >>

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Brendan Higgins
On Tue, Aug 27, 2019 at 3:00 PM shuah wrote: > > On 8/27/19 3:36 PM, Brendan Higgins wrote: > > On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins > > wrote: > >> > >> On Tue, Aug 27, 2019 at 2:03 PM Brendan Higgins > >> wrote: > >>> > >>> On Tue, Aug 27, 2019 at 1:21 PM shuah wrote: > >

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread shuah
On 8/27/19 3:36 PM, Brendan Higgins wrote: On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins wrote: On Tue, Aug 27, 2019 at 2:03 PM Brendan Higgins wrote: On Tue, Aug 27, 2019 at 1:21 PM shuah wrote: On 8/27/19 11:49 AM, Brendan Higgins wrote: Previously KUnit assumed that printk would

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Brendan Higgins
On Tue, Aug 27, 2019 at 2:46 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-27 10:49:32) > > Previously KUnit assumed that printk would always be present, which is > > not a valid assumption to make. Fix that by ifdefing out functions which > > directly depend on printk core

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-27 10:49:32) > Previously KUnit assumed that printk would always be present, which is > not a valid assumption to make. Fix that by ifdefing out functions which > directly depend on printk core functions similar to what dev_printk > does. > > Reported-by: Randy

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Brendan Higgins
On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins wrote: > > On Tue, Aug 27, 2019 at 2:03 PM Brendan Higgins > wrote: > > > > On Tue, Aug 27, 2019 at 1:21 PM shuah wrote: > > > > > > On 8/27/19 11:49 AM, Brendan Higgins wrote: > > > > Previously KUnit assumed that printk would always be present,

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread shuah
On 8/27/19 2:53 PM, Randy Dunlap wrote: On 8/27/19 1:21 PM, shuah wrote: On 8/27/19 11:49 AM, Brendan Higgins wrote: Previously KUnit assumed that printk would always be present, which is not a valid assumption to make. Fix that by ifdefing out functions which directly depend on printk core

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Brendan Higgins
On Tue, Aug 27, 2019 at 2:03 PM Brendan Higgins wrote: > > On Tue, Aug 27, 2019 at 1:21 PM shuah wrote: > > > > On 8/27/19 11:49 AM, Brendan Higgins wrote: > > > Previously KUnit assumed that printk would always be present, which is > > > not a valid assumption to make. Fix that by ifdefing out

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Brendan Higgins
On Tue, Aug 27, 2019 at 1:21 PM shuah wrote: > > On 8/27/19 11:49 AM, Brendan Higgins wrote: > > Previously KUnit assumed that printk would always be present, which is > > not a valid assumption to make. Fix that by ifdefing out functions which > > directly depend on printk core functions similar

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Randy Dunlap
On 8/27/19 1:21 PM, shuah wrote: > On 8/27/19 11:49 AM, Brendan Higgins wrote: >> Previously KUnit assumed that printk would always be present, which is >> not a valid assumption to make. Fix that by ifdefing out functions which >> directly depend on printk core functions similar to what

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread shuah
On 8/27/19 11:49 AM, Brendan Higgins wrote: Previously KUnit assumed that printk would always be present, which is not a valid assumption to make. Fix that by ifdefing out functions which directly depend on printk core functions similar to what dev_printk does. Reported-by: Randy Dunlap Link:

Re: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Randy Dunlap
On 8/27/19 10:49 AM, Brendan Higgins wrote: > Previously KUnit assumed that printk would always be present, which is > not a valid assumption to make. Fix that by ifdefing out functions which > directly depend on printk core functions similar to what dev_printk > does. > > Reported-by: Randy