Hi Sakari,
> Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs
>
> Hi Rajmohan and Andy,
>
> On Sun, Jun 11, 2017 at 03:49:18AM +, Mani, Rajmohan wrote:
> > Hi Andy,
> >
> > Thanks for the reviews and patience.
> >
> > >
>
On Mon, Jun 12, 2017 at 12:17 PM, Mani, Rajmohan
wrote:
>> Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs
>> On Sun, Jun 11, 2017 at 7:50 PM, Sakari Ailus wrote:
>> > On Sun, Jun 11, 2017 at 04:40:16PM +0300, Andy Shevchenko wrote:
>> >> On Sun
Hi Andy, Sakari,
> Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs
>
> On Sun, Jun 11, 2017 at 7:50 PM, Sakari Ailus wrote:
> > On Sun, Jun 11, 2017 at 04:40:16PM +0300, Andy Shevchenko wrote:
> >> On Sun, Jun 11, 2017 at 2:30 PM, Sakari Ailus wrote:
Hi Linus,
> Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs
> > +static inline struct tps68470_gpio_data *to_gpio_data(struct
> > +gpio_chip *gpiochp) {
> > + return container_of(gpiochp, struct tps68470_gpio_data, gc); }
>
> Please use the d
On Sun, Jun 11, 2017 at 7:50 PM, Sakari Ailus wrote:
> On Sun, Jun 11, 2017 at 04:40:16PM +0300, Andy Shevchenko wrote:
>> On Sun, Jun 11, 2017 at 2:30 PM, Sakari Ailus wrote:
>> > Again, I'm not really worried about this driver, but the ACPI tables. How
>> > does the difference show there?
>>
>
Hi Andy,
On Sun, Jun 11, 2017 at 04:40:16PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 11, 2017 at 2:30 PM, Sakari Ailus wrote:
> > On Sun, Jun 11, 2017 at 03:49:18AM +, Mani, Rajmohan wrote:
> >> > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani
> >> > wrote:
>
> >> > Besides my below comme
On Sun, Jun 11, 2017 at 2:30 PM, Sakari Ailus wrote:
> On Sun, Jun 11, 2017 at 03:49:18AM +, Mani, Rajmohan wrote:
>> > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani
>> > wrote:
>> > Besides my below comments, just put it here that I recommended earlier to
>> > provide 2 GPIO chips (one per
Hi Rajmohan and Andy,
On Sun, Jun 11, 2017 at 03:49:18AM +, Mani, Rajmohan wrote:
> Hi Andy,
>
> Thanks for the reviews and patience.
>
> >
> > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani
> > wrote:
> > > This patch adds support for TPS68470 GPIOs.
> > > There are 7 GPIOs and a few senso
ones ;
> Alexandre Courbot ; Rafael J. Wysocki
> ; Len Brown
> Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs
>
> On Tue, Jun 6, 2017 at 1:55 PM, Rajmohan Mani
> wrote:
>
> > This patch adds support for TPS68470 GPIOs.
> > There are 7 GPIOs and
Hi Andy,
Thanks for the reviews and patience.
>
> On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani
> wrote:
> > This patch adds support for TPS68470 GPIOs.
> > There are 7 GPIOs and a few sensor related GPIOs.
> > These GPIOs can be requested and configured as appropriate.
>
> Besides my below co
On Tue, Jun 6, 2017 at 1:55 PM, Rajmohan Mani wrote:
> This patch adds support for TPS68470 GPIOs.
> There are 7 GPIOs and a few sensor related GPIOs.
> These GPIOs can be requested and configured as
> appropriate.
>
> Signed-off-by: Rajmohan Mani
Same comments as Andy already sent, plus:
> +s
On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani wrote:
> This patch adds support for TPS68470 GPIOs.
> There are 7 GPIOs and a few sensor related GPIOs.
> These GPIOs can be requested and configured as
> appropriate.
Besides my below comments, just put it here that I recommended earlier
to provide
12 matches
Mail list logo