Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest

2018-07-11 Thread Vinod
On 11-07-18, 08:16, Robin Gong wrote: > > > The problem seems to be that we do not know whether we are doing > > > memcpy or not. Normally we get the information how a channel is to be > > > configured in dma_device->device_config, but this function is not > > > called in the memcpy case. > > > >

RE: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest

2018-07-11 Thread Robin Gong
t; ker...@pengutronix.de; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest > > On 11-07-18, 08:53, s.ha...@pengutronix.de wrote: > > On Wed, Jul 11, 2018 at 06:37:02AM +, Robin Gong

Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest

2018-07-11 Thread Vinod
ng > > > Cc: dan.j.willi...@intel.com; shawn...@kernel.org; > > > s.ha...@pengutronix.de; Fabio Estevam ; > > > li...@armlinux.org.uk; linux-arm-ker...@lists.infradead.org; > > > ker...@pengutronix.de; dmaeng...@vger.kernel.org; > > > linux-kernel@vger.kernel

RE: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest

2018-07-11 Thread Robin Gong
.infradead.org; > ker...@pengutronix.de; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest > > On Wed, Jul 11, 2018 at 06:37:02AM +, Robin Gong wrote: > > > > > -Original Mess

Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest

2018-07-10 Thread s.ha...@pengutronix.de
@pengutronix.de; Fabio Estevam ; > > li...@armlinux.org.uk; linux-arm-ker...@lists.infradead.org; > > ker...@pengutronix.de; dmaeng...@vger.kernel.org; > > linux-kernel@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest > > >

RE: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest

2018-07-10 Thread Robin Gong
t; ker...@pengutronix.de; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest > > On 11-07-18, 00:23, Robin Gong wrote: > > dmatest(memcpy) will never call dmaengine_slave_config before prep, &g

Re: [PATCH v1 3/4] dmaengine: imx-sdma: support dmatest

2018-07-10 Thread Vinod
On 11-07-18, 00:23, Robin Gong wrote: > dmatest(memcpy) will never call dmaengine_slave_config before prep, and that should have been a hint to you that you should not expect that > so jobs in dmaengine_slave_config need to be moved into somewhere > before device_prep_dma_memcpy. Besides, dmatest