Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Alexander Duyck
On Thu, Jul 18, 2019 at 1:49 PM Michael S. Tsirkin wrote: > > On Thu, Jul 18, 2019 at 01:34:03PM -0700, Alexander Duyck wrote: > > On Thu, Jul 18, 2019 at 1:24 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Jul 18, 2019 at 08:34:37AM -0700, Alexander Duyck wrote: > > > > > > > For example we

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Alexander Duyck
On Thu, Jul 18, 2019 at 1:37 PM Michael S. Tsirkin wrote: > > On Thu, Jul 18, 2019 at 01:29:14PM -0700, Alexander Duyck wrote: > > So one thing that is still an issue then is that my approach would > > only work on the first migration. The problem is the logic I have > > implemented assumes that

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2019 at 01:34:03PM -0700, Alexander Duyck wrote: > On Thu, Jul 18, 2019 at 1:24 PM Michael S. Tsirkin wrote: > > > > On Thu, Jul 18, 2019 at 08:34:37AM -0700, Alexander Duyck wrote: > > > > > > For example we allocate pages until shrinker kicks in. > > > > > > Fair enough but in

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2019 at 01:29:14PM -0700, Alexander Duyck wrote: > So one thing that is still an issue then is that my approach would > only work on the first migration. The problem is the logic I have > implemented assumes that once we have hinted on a page we don't need > to do it again. However

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Alexander Duyck
On Thu, Jul 18, 2019 at 1:24 PM Michael S. Tsirkin wrote: > > On Thu, Jul 18, 2019 at 08:34:37AM -0700, Alexander Duyck wrote: > > > > > For example we allocate pages until shrinker kicks in. > > > > > Fair enough but in fact many it would be better to > > > > > do the reverse: trigger shrinker

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Alexander Duyck
On Thu, Jul 18, 2019 at 9:07 AM Michael S. Tsirkin wrote: > > On Thu, Jul 18, 2019 at 08:34:37AM -0700, Alexander Duyck wrote: > > On Wed, Jul 17, 2019 at 10:14 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 17, 2019 at 09:43:52AM -0700, Alexander Duyck wrote: > > > > On Wed, Jul 17, 2019

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2019 at 12:03:23PM -0400, Nitesh Narayan Lal wrote: > For example we allocate pages until shrinker kicks in. > Fair enough but in fact many it would be better to > do the reverse: trigger shrinker and then send as many > free pages as we can to host. > >>> I'm

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2019 at 08:34:37AM -0700, Alexander Duyck wrote: > > > > For example we allocate pages until shrinker kicks in. > > > > Fair enough but in fact many it would be better to > > > > do the reverse: trigger shrinker and then send as many > > > > free pages as we can to host. > > > > >

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2019 at 08:34:37AM -0700, Alexander Duyck wrote: > On Wed, Jul 17, 2019 at 10:14 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 17, 2019 at 09:43:52AM -0700, Alexander Duyck wrote: > > > On Wed, Jul 17, 2019 at 3:28 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue,

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Nitesh Narayan Lal
On 7/18/19 11:34 AM, Alexander Duyck wrote: > On Wed, Jul 17, 2019 at 10:14 PM Michael S. Tsirkin wrote: >> On Wed, Jul 17, 2019 at 09:43:52AM -0700, Alexander Duyck wrote: >>> On Wed, Jul 17, 2019 at 3:28 AM Michael S. Tsirkin wrote: On Tue, Jul 16, 2019 at 02:06:59PM -0700, Alexander

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-18 Thread Alexander Duyck
On Wed, Jul 17, 2019 at 10:14 PM Michael S. Tsirkin wrote: > > On Wed, Jul 17, 2019 at 09:43:52AM -0700, Alexander Duyck wrote: > > On Wed, Jul 17, 2019 at 3:28 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 16, 2019 at 02:06:59PM -0700, Alexander Duyck wrote: > > > > On Tue, Jul 16, 2019

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-17 Thread Michael S. Tsirkin
On Wed, Jul 17, 2019 at 09:43:52AM -0700, Alexander Duyck wrote: > On Wed, Jul 17, 2019 at 3:28 AM Michael S. Tsirkin wrote: > > > > On Tue, Jul 16, 2019 at 02:06:59PM -0700, Alexander Duyck wrote: > > > On Tue, Jul 16, 2019 at 10:41 AM Michael S. Tsirkin > > > wrote: > > > > > > > > > > > > >

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-17 Thread Alexander Duyck
On Wed, Jul 17, 2019 at 3:28 AM Michael S. Tsirkin wrote: > > On Tue, Jul 16, 2019 at 02:06:59PM -0700, Alexander Duyck wrote: > > On Tue, Jul 16, 2019 at 10:41 AM Michael S. Tsirkin wrote: > > > > > > > > > > > This is what I am saying. Having watched that patchset being > > > > > developed,

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-17 Thread Michael S. Tsirkin
On Tue, Jul 16, 2019 at 02:06:59PM -0700, Alexander Duyck wrote: > On Tue, Jul 16, 2019 at 10:41 AM Michael S. Tsirkin wrote: > > > > > > > This is what I am saying. Having watched that patchset being developed, > > > > I think that's simply because processing blocks required mm core > > > >

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Alexander Duyck
On Tue, Jul 16, 2019 at 10:41 AM Michael S. Tsirkin wrote: > > > This is what I am saying. Having watched that patchset being developed, > > > I think that's simply because processing blocks required mm core > > > changes, which Wei was not up to pushing through. > > > > > > > > > If we did >

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Michael S. Tsirkin
On Tue, Jul 16, 2019 at 09:54:37AM -0700, Alexander Duyck wrote: > On Tue, Jul 16, 2019 at 9:08 AM Michael S. Tsirkin wrote: > > > > On Tue, Jul 16, 2019 at 08:37:06AM -0700, Alexander Duyck wrote: > > > On Tue, Jul 16, 2019 at 2:55 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Jun

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Alexander Duyck
On Tue, Jul 16, 2019 at 9:08 AM Michael S. Tsirkin wrote: > > On Tue, Jul 16, 2019 at 08:37:06AM -0700, Alexander Duyck wrote: > > On Tue, Jul 16, 2019 at 2:55 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Jun 19, 2019 at 03:33:38PM -0700, Alexander Duyck wrote: > > > > From: Alexander Duyck

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Michael S. Tsirkin
On Tue, Jul 16, 2019 at 03:01:52PM +, Wang, Wei W wrote: > On Tuesday, July 16, 2019 10:41 PM, Hansen, Dave wrote: > > Where is the page allocator integration? The set you linked to has 5 > > patches, > > but only 4 were merged. This one is missing: > > > >

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Michael S. Tsirkin
On Tue, Jul 16, 2019 at 08:37:06AM -0700, Alexander Duyck wrote: > On Tue, Jul 16, 2019 at 2:55 AM Michael S. Tsirkin wrote: > > > > On Wed, Jun 19, 2019 at 03:33:38PM -0700, Alexander Duyck wrote: > > > From: Alexander Duyck > > > > > > Add support for aerating memory using the hinting feature

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Alexander Duyck
On Tue, Jul 16, 2019 at 2:55 AM Michael S. Tsirkin wrote: > > On Wed, Jun 19, 2019 at 03:33:38PM -0700, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Add support for aerating memory using the hinting feature provided by > > virtio-balloon. Hinting differs from the regular balloon

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Michael S. Tsirkin
On Tue, Jul 16, 2019 at 04:17:13PM +0200, David Hildenbrand wrote: > On 16.07.19 16:12, David Hildenbrand wrote: > > On 16.07.19 16:00, Dave Hansen wrote: > >> On 7/16/19 2:55 AM, Michael S. Tsirkin wrote: > >>> The approach here is very close to what on-demand hinting that is > >>> already

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread David Hildenbrand
On 16.07.19 16:41, Dave Hansen wrote: > On 7/16/19 7:12 AM, David Hildenbrand wrote: >> On 16.07.19 16:00, Dave Hansen wrote: >>> On 7/16/19 2:55 AM, Michael S. Tsirkin wrote: The approach here is very close to what on-demand hinting that is already upstream does. >>> Are you referring

RE: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Wang, Wei W
On Tuesday, July 16, 2019 10:41 PM, Hansen, Dave wrote: > Where is the page allocator integration? The set you linked to has 5 patches, > but only 4 were merged. This one is missing: > > https://lore.kernel.org/patchwork/patch/961038/ For some reason, we used the regular page allocation

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Dave Hansen
On 7/16/19 7:12 AM, David Hildenbrand wrote: > On 16.07.19 16:00, Dave Hansen wrote: >> On 7/16/19 2:55 AM, Michael S. Tsirkin wrote: >>> The approach here is very close to what on-demand hinting that is >>> already upstream does. >> Are you referring to the s390 (and powerpc) stuff that is hidden

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread David Hildenbrand
On 16.07.19 16:12, David Hildenbrand wrote: > On 16.07.19 16:00, Dave Hansen wrote: >> On 7/16/19 2:55 AM, Michael S. Tsirkin wrote: >>> The approach here is very close to what on-demand hinting that is >>> already upstream does. >> >> Are you referring to the s390 (and powerpc) stuff that is

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread David Hildenbrand
On 16.07.19 16:00, Dave Hansen wrote: > On 7/16/19 2:55 AM, Michael S. Tsirkin wrote: >> The approach here is very close to what on-demand hinting that is >> already upstream does. > > Are you referring to the s390 (and powerpc) stuff that is hidden behind > arch_free_page()? > I assume Michael

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Dave Hansen
On 7/16/19 2:55 AM, Michael S. Tsirkin wrote: > The approach here is very close to what on-demand hinting that is > already upstream does. Are you referring to the s390 (and powerpc) stuff that is hidden behind arch_free_page()?

Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting

2019-07-16 Thread Michael S. Tsirkin
On Wed, Jun 19, 2019 at 03:33:38PM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Add support for aerating memory using the hinting feature provided by > virtio-balloon. Hinting differs from the regular balloon functionality in > that is is much less durable than a standard memory