RE: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

> -Original Message- > From: Matt Fleming [mailto:m...@codeblueprint.co.uk] > Sent: Thursday, January 28, 2016 8:16 PM > > On Tue, 26 Jan, at 03:10:03AM, Kweh Hock Leong wrote: > > > > > > This mutex is not needed. It doesn't protect anything in your code. > > > > This is to

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Tue, 26 Jan, at 03:10:03AM, Kweh Hock Leong wrote: > > > > This mutex is not needed. It doesn't protect anything in your code. > > This is to synchronize/serializes one of the instant is calling > efi_capsule_supported() > and the other one is calling efi_capsule_update() which they are

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Tue, 26 Jan, at 03:10:03AM, Kweh Hock Leong wrote: > > > > This mutex is not needed. It doesn't protect anything in your code. > > This is to synchronize/serializes one of the instant is calling > efi_capsule_supported() > and the other one is calling efi_capsule_update() which they are

RE: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

> -Original Message- > From: Matt Fleming [mailto:m...@codeblueprint.co.uk] > Sent: Thursday, January 28, 2016 8:16 PM > > On Tue, 26 Jan, at 03:10:03AM, Kweh Hock Leong wrote: > > > > > > This mutex is not needed. It doesn't protect anything in your code. > > > > This is to

RE: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

> -Original Message- > From: Matt Fleming [mailto:m...@console-pimps.org] > Sent: Thursday, January 21, 2016 7:52 PM > > On Fri, 18 Dec, at 08:13:01PM, Kweh Hock Leong wrote: > > From: "Kweh, Hock Leong" > > > > Introducing a kernel module to expose capsule loader interface > > (misc

RE: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

> -Original Message- > From: Bryan O'Donoghue [mailto:pure.lo...@nexus-software.ie] > Sent: Tuesday, December 22, 2015 1:04 AM > > Small nit. > Hi, Sorry for the late response. Happy New Year. > On Fri, 2015-12-18 at 20:13 +0800, Kweh, Hock Leong wrote: > > From: "Kweh, Hock Leong" >

RE: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

> -Original Message- > From: Matt Fleming [mailto:m...@console-pimps.org] > Sent: Thursday, January 21, 2016 7:52 PM > > On Fri, 18 Dec, at 08:13:01PM, Kweh Hock Leong wrote: > > From: "Kweh, Hock Leong" > > > > Introducing a kernel module to expose capsule

RE: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

> -Original Message- > From: Bryan O'Donoghue [mailto:pure.lo...@nexus-software.ie] > Sent: Tuesday, December 22, 2015 1:04 AM > > Small nit. > Hi, Sorry for the late response. Happy New Year. > On Fri, 2015-12-18 at 20:13 +0800, Kweh, Hock Leong wrote: > > From: "Kweh, Hock Leong"

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Mon, 21 Dec, at 05:04:11PM, Bryan O'Donoghue wrote: > > +static int efi_capsule_open(struct inode *inode, struct file *file) > > +{ > > + struct capsule_info *cap_info; > > + > > + cap_info = kzalloc(sizeof(*cap_info), GFP_KERNEL); > > + if (!cap_info) > > + return -ENOMEM; > >

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Fri, 18 Dec, at 08:13:01PM, Kweh Hock Leong wrote: > From: "Kweh, Hock Leong" > > Introducing a kernel module to expose capsule loader interface > (misc char device file note) for user to upload capsule binaries. > > Example method to load the capsule binary: > cat firmware.bin >

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Fri, 18 Dec, at 08:13:01PM, Kweh Hock Leong wrote: > From: "Kweh, Hock Leong" > > Introducing a kernel module to expose capsule loader interface > (misc char device file note) for user to upload capsule binaries. > > Example method to load the capsule binary: > cat

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Mon, 21 Dec, at 05:04:11PM, Bryan O'Donoghue wrote: > > +static int efi_capsule_open(struct inode *inode, struct file *file) > > +{ > > + struct capsule_info *cap_info; > > + > > + cap_info = kzalloc(sizeof(*cap_info), GFP_KERNEL); > > + if (!cap_info) > > + return -ENOMEM; > >

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Mon, 2015-12-21 at 18:37 +0100, Borislav Petkov wrote: > On Mon, Dec 21, 2015 at 05:04:11PM +, Bryan O'Donoghue wrote: > > > This patch also export efi_capsule_supported() function symbol > > > for > > > verifying the submitted capsule header in this kernel module. > > > > 1. Should be a

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Mon, Dec 21, 2015 at 05:04:11PM +, Bryan O'Donoghue wrote: > > This patch also export efi_capsule_supported() function symbol for > > verifying the submitted capsule header in this kernel module. > > 1. Should be a separate patch > 2. Suggested, rewording for that patch log > > 2/2 Title

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

Small nit. On Fri, 2015-12-18 at 20:13 +0800, Kweh, Hock Leong wrote: > From: "Kweh, Hock Leong" > > Introducing a kernel module to expose capsule loader interface > (misc char device file note) for user to upload capsule binaries. This patch ? introduces a kernel module to expose a capsule

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

Small nit. On Fri, 2015-12-18 at 20:13 +0800, Kweh, Hock Leong wrote: > From: "Kweh, Hock Leong" > > Introducing a kernel module to expose capsule loader interface > (misc char device file note) for user to upload capsule binaries. This patch ? introduces a kernel

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Mon, Dec 21, 2015 at 05:04:11PM +, Bryan O'Donoghue wrote: > > This patch also export efi_capsule_supported() function symbol for > > verifying the submitted capsule header in this kernel module. > > 1. Should be a separate patch > 2. Suggested, rewording for that patch log > > 2/2 Title

Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

On Mon, 2015-12-21 at 18:37 +0100, Borislav Petkov wrote: > On Mon, Dec 21, 2015 at 05:04:11PM +, Bryan O'Donoghue wrote: > > > This patch also export efi_capsule_supported() function symbol > > > for > > > verifying the submitted capsule header in this kernel module. > > > > 1. Should be a