Re: [PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script

2020-08-11 Thread Frieder Schrempf
On 10.08.20 12:57, Robin Gong wrote: On 2020/08/10 15:33 Frieder Schrempf wrote: Hi Robin, This patch seems to break UART DMA in case the ROM firmware is used. In that case sdma->script_number is set to SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1, so the ROM scripts at uart_2_mcu_addr and uartsh_2_mcu_add

Re: [PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script

2020-08-10 Thread Robert Schwebel
On Mon, Aug 10, 2020 at 10:57:42AM +, Robin Gong wrote: > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 5900e32..4db55b9 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1754,6 +1754,19 @@ static void sdma_add_scripts(struct sdma_engine *sdma, >

RE: [PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script

2020-08-10 Thread Robin Gong
On 2020/08/10 15:33 Frieder Schrempf wrote: > Hi Robin, > > This patch seems to break UART DMA in case the ROM firmware is used. In that > case sdma->script_number is set to SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1, so > the ROM scripts at uart_2_mcu_addr and uartsh_2_mcu_addr will never be > added in sdm

Re: [PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script

2020-08-10 Thread Frieder Schrempf
Hi Robin, On 24.07.20 20:51, Robin Gong wrote: For the compatibility of NXP internal legacy kernel before 4.19 which is based on uart ram script and upstreaming kernel based on uart rom script, add both uart ram/rom script in latest sdma firmware. By default uart rom script used. Besides, add tw