RE: [PATCH v14 3/3] Input: new da7280 haptic driver

2020-06-28 Thread Roy Im
On Sat, June 27, 2020 12:56 AM, Uwe Kleine-König wrote: > On Fri, Jun 26, 2020 at 01:17:29PM +, Roy Im wrote: > > > On Fri, June 26, 2020 3:19 PM, Uwe Kleine-König wrote: > > > Hello, > > > from the PWM POV I'm happy now. Just a few minor comments that I noticed > > > while checking the PWM de

Re: [PATCH v14 3/3] Input: new da7280 haptic driver

2020-06-26 Thread Uwe Kleine-König
On Fri, Jun 26, 2020 at 01:17:29PM +, Roy Im wrote: > > On Fri, June 26, 2020 3:19 PM, Uwe Kleine-König wrote: > > Hello, > > from the PWM POV I'm happy now. Just a few minor comments that I noticed > > while checking the PWM details. > > Many thanks for your comments. > > > > > On Thu, Jun

RE: [PATCH v14 3/3] Input: new da7280 haptic driver

2020-06-26 Thread Roy Im
> On Fri, June 26, 2020 3:19 PM, Uwe Kleine-König wrote: > Hello, > from the PWM POV I'm happy now. Just a few minor comments that I noticed > while checking the PWM details. Many thanks for your comments. > > On Thu, Jun 25, 2020 at 01:59:29AM +0900, Roy Im wrote: > > + val = haptics

Re: [PATCH v14 3/3] Input: new da7280 haptic driver

2020-06-25 Thread Uwe Kleine-König
Hello, from the PWM POV I'm happy now. Just a few minor comments that I noticed while checking the PWM details. On Thu, Jun 25, 2020 at 01:59:29AM +0900, Roy Im wrote: > + val = haptics->ps_seq_id << DA7280_PS_SEQ_ID_SHIFT | > + haptics->ps_seq_loop << DA7280_PS_SE