Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-27 Thread Chao Xie
hi, Arnd SCU registers mapping can not be added to fixmap. As Russell's suggested, the SCU registers can be mapped to 0x1000 with single page. Beause the mapping is not a fix map, and i can not use the static functions in arch/arm/mm/mm.h, I still have to use static mapping for SCU registers by

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-19 Thread Chao Xie
On Tue, Jun 18, 2013 at 5:34 AM, Arnd Bergmann wrote: > On Monday 17 June 2013, Chao Xie wrote: >> On Fri, Jun 14, 2013 at 8:56 PM, Arnd Bergmann wrote: >> > On Friday 14 June 2013 17:15:33 Chao Xie wrote: >> >> On Mon, Jun 10, 2013 at 4:35 PM, Arnd Bergmann wrote: >> > >> >> > I guess that is a

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-17 Thread Arnd Bergmann
On Monday 17 June 2013, Chao Xie wrote: > On Fri, Jun 14, 2013 at 8:56 PM, Arnd Bergmann wrote: > > On Friday 14 June 2013 17:15:33 Chao Xie wrote: > >> On Mon, Jun 10, 2013 at 4:35 PM, Arnd Bergmann wrote: > > > >> > I guess that is a problem we have on other platforms as well, we should > >> >

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-16 Thread Chao Xie
On Fri, Jun 14, 2013 at 8:56 PM, Arnd Bergmann wrote: > On Friday 14 June 2013 17:15:33 Chao Xie wrote: >> On Mon, Jun 10, 2013 at 4:35 PM, Arnd Bergmann wrote: > >> > I guess that is a problem we have on other platforms as well, we should >> > find a generic solution for that. It would be nice t

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-14 Thread Arnd Bergmann
On Friday 14 June 2013 17:15:33 Chao Xie wrote: > On Mon, Jun 10, 2013 at 4:35 PM, Arnd Bergmann wrote: > > I guess that is a problem we have on other platforms as well, we should > > find a generic solution for that. It would be nice to reserve a page > > in "fixmap" and have common code map the

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-14 Thread Chao Xie
On Mon, Jun 10, 2013 at 4:35 PM, Arnd Bergmann wrote: > >> >> > __initdata = { >> >> > > .virtual= (unsigned long)AXI_VIRT_BASE, >> >> > > .length = AXI_PHYS_SIZE, >> >> > > .type = MT_DEVICE, >> >> > > - }, >> >> > > + }, { >> >> > > +

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-10 Thread Arnd Bergmann
On Saturday 08 June 2013, Chao Xie wrote: > hi, Arnd > Thanks for your review. > > On Fri, Jun 7, 2013 at 12:26 AM, Arnd Bergmann wrote: > > On Thursday 06 June 2013, Neil Zhang wrote: > >> > >> The MACH_MMPX_DT here is for standard ARM core based SoC. > >> But PJ4 is modified by Marvell, which i

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-07 Thread Chao Xie
hi, Arnd Thanks for your review. On Fri, Jun 7, 2013 at 12:26 AM, Arnd Bergmann wrote: > On Thursday 06 June 2013, Neil Zhang wrote: >> > > diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig >> > > index ebdda83..0955191 100644 >> > > --- a/arch/arm/mach-mmp/Kconfig >> > > +++ b/a

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-06 Thread Arnd Bergmann
On Thursday 06 June 2013, Neil Zhang wrote: > > > diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig > > > index ebdda83..0955191 100644 > > > --- a/arch/arm/mach-mmp/Kconfig > > > +++ b/arch/arm/mach-mmp/Kconfig > > > @@ -107,6 +107,16 @@ config MACH_MMP2_DT > > > Include suppo

RE: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-06-05 Thread Neil Zhang
Hi Arnd, > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 2013年5月31日 19:25 > To: linux-arm-ker...@lists.infradead.org > Cc: Neil Zhang; haojian.zhu...@gmail.com; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] ARM: mmp: bring up pxa98

Re: [PATCH v2] ARM: mmp: bring up pxa988 with device tree support

2013-05-31 Thread Arnd Bergmann
On Friday 31 May 2013 10:58:35 Neil Zhang wrote: > bring up pxa988 with device tree support. > > Change-Id: I6fc869b7d5ff8dc6e4eb0042a89429200f7a9fb1 Please don't post silly extra headers like that. > Signed-off-by: Neil Zhang A couple of comments on the DT structure: > + gic: interrupt-c