Re: [PATCH v2] Move the definition of pr_err() into kernel.h

2007-09-11 Thread Felipe Balbi
Hi, On 9/11/07, Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> wrote: > > -#define pr_err(fmt, arg...) printk(KERN_ERR DRIVER_NAME ": > > ", ## arg); > > - > > Unnecessary whitespace removal. Actually... I prefer removing the extra blank-line... it's easier to read and keeps on blank-line only to

RE: [PATCH v2] Move the definition of pr_err() into kernel.h

2007-09-11 Thread Medve Emilian-EMMEDVE1
> -Original Message- > From: Waskiewicz Jr, Peter P [mailto:[EMAIL PROTECTED] > Sent: Tuesday, September 11, 2007 2:48 PM > To: Medve Emilian-EMMEDVE1; linux-kernel@vger.kernel.org; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED] > Subject: RE: [PATCH v2] Move the definition

RE: [PATCH v2] Move the definition of pr_err() into kernel.h

2007-09-11 Thread Waskiewicz Jr, Peter P
> Other pr_*() macros are already defined in kernel.h, but > pr_err() was defined multiple times in several other places > > Signed-off-by: Emil Medve <[EMAIL PROTECTED]> > --- > > I'm writing a driver and I've been using the pr_*() macros > from kernel.h and I was surprised not to find there

RE: [PATCH v2] Move the definition of pr_err() into kernel.h

2007-09-11 Thread Waskiewicz Jr, Peter P
Other pr_*() macros are already defined in kernel.h, but pr_err() was defined multiple times in several other places Signed-off-by: Emil Medve [EMAIL PROTECTED] --- I'm writing a driver and I've been using the pr_*() macros from kernel.h and I was surprised not to find there pr_err()

RE: [PATCH v2] Move the definition of pr_err() into kernel.h

2007-09-11 Thread Medve Emilian-EMMEDVE1
-Original Message- From: Waskiewicz Jr, Peter P [mailto:[EMAIL PROTECTED] Sent: Tuesday, September 11, 2007 2:48 PM To: Medve Emilian-EMMEDVE1; linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: RE: [PATCH v2] Move the definition of

Re: [PATCH v2] Move the definition of pr_err() into kernel.h

2007-09-11 Thread Felipe Balbi
Hi, On 9/11/07, Waskiewicz Jr, Peter P [EMAIL PROTECTED] wrote: snip -#define pr_err(fmt, arg...) printk(KERN_ERR DRIVER_NAME : , ## arg); - Unnecessary whitespace removal. Actually... I prefer removing the extra blank-line... it's easier to read and keeps on blank-line only to