RE: [PATCH v2] Thermal: exynos: Add sysfs node supporting exynos's emulation mode.

2012-10-31 Thread R, Durgadoss
Hi, [A big cut.] > >> + > >> + mutex_lock(&data->lock); > >> + clk_enable(data->clk); > >> + > >> + reg = readl(data->base + EXYNOS_EMUL_CON); > >> + enable = reg & EXYNOS_EMUL_ENABLE; > >> + if (!enable && !temp) > >> + goto out; > > I think you what you are trying to do here is thi

Re: [PATCH v2] Thermal: exynos: Add sysfs node supporting exynos's emulation mode.

2012-10-31 Thread jonghwa3 . lee
On 2012년 10월 31일 15:45, R, Durgadoss wrote: > Hi, > > Looks like a nice feature :-) > Without something like this, we had been spending time on > writing test drivers, to actually test our thermal framework code. Yes, fortunately, Exynos SOCs emulation mode makes our life better. ; ) > BTW, against

RE: [PATCH v2] Thermal: exynos: Add sysfs node supporting exynos's emulation mode.

2012-10-30 Thread R, Durgadoss
Hi, Looks like a nice feature :-) Without something like this, we had been spending time on writing test drivers, to actually test our thermal framework code. BTW, against which tree this patch was generated ? Rui's -next or master or Linux-next ? Some comments below, on a quick glance.. >