RE: [PATCH v2] alarmtimer: fix unexpected rtc interrupt when system resume from S3

2015-11-17 Thread Thomas Gleixner
On Tue, 17 Nov 2015, Lee, Zhuo-hao wrote: Can you please fix your e-mail client to do proper line breaks around 80 char? > >> (1). alarmtimer create a rtc wake up timer however alarmtimer won't > >> remove that timer if the system wake up earlier > > > That's hardly a bug. That's a slight i

RE: [PATCH v2] alarmtimer: fix unexpected rtc interrupt when system resume from S3

2015-11-16 Thread Lee, Zhuo-hao
>> (1). alarmtimer create a rtc wake up timer however alarmtimer won't >> remove that timer if the system wake up earlier >That's hardly a bug. That's a slight incorrectness which needs to be fixed. I think this timer is useless after system resume. For the correctness, I think it should be

RE: [PATCH v2] alarmtimer: fix unexpected rtc interrupt when system resume from S3

2015-11-16 Thread Thomas Gleixner
On Sat, 14 Nov 2015, Lee, Zhuo-hao wrote: > (1). alarmtimer create a rtc wake up timer however alarmtimer won't > remove that timer if the system wake up earlier That's hardly a bug. That's a slight incorrectness which needs to be fixed. > (2). rtc wake up timer will trigger hpet_rtc_interr

RE: [PATCH v2] alarmtimer: fix unexpected rtc interrupt when system resume from S3

2015-11-14 Thread Lee, Zhuo-hao
>If you could, please CC me on future submissions? I need to add an entry to >MAINTAINERS >for alarmtimers. :) Ok, I will do that on the future submissions :) >> Before the system go to suspend (S3), if user create a timer with >> clockid CLOCK_REALTIME_ALARM/CLOCK_BOOTTIME_ALARM and set a "lar

Re: [PATCH v2] alarmtimer: fix unexpected rtc interrupt when system resume from S3

2015-11-13 Thread John Stultz
On Wed, Nov 4, 2015 at 9:50 PM, wrote: > From: zhuo-hao > If you could, please CC me on future submissions? I need to add an entry to MAINTAINERS for alarmtimers. :) > Before the system go to suspend (S3), if user create a timer with clockid > CLOCK_REALTIME_ALARM/CLOCK_BOOTTIME_ALARM and set

RE: [PATCH v2] alarmtimer: fix unexpected rtc interrupt when system resume from S3

2015-11-08 Thread Lee, Zhuo-hao
Hi tglx & all, I wrote a simple program which can always hit this problem. Please use gcc to compile the following code and then "./a.out 1 1" and watch the /proc/interrupts, and you will see that the RTC interrupt will come unexpectedly after system resumed. This abnormal interrupt should