Re: [PATCH v2] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-25 Thread Vignesh R
g; >> marek.va...@gmail.com; rich...@nod.at; joakim.tjernl...@infinera.com; >> ikeg...@allied-telesis.co.jp; keesc...@chromium.org >> Cc: linux-...@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v2] cfi: fix deadloop in cfi_cmdset_0002.c >>

RE: [PATCH v2] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-22 Thread liujian (CE)
finera.com; > ikeg...@allied-telesis.co.jp; keesc...@chromium.org > Cc: linux-...@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer > > > > On 20/02/19 2:17 AM, Liu Jian wrote: > > In function d

Re: [PATCH v2] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-21 Thread Vignesh R
On 20/02/19 2:17 AM, Liu Jian wrote: > In function do_write_buffer(), in the for loop, there is a case > chip_ready() returns 1 while chip_good() returns 0, so it never > break the loop. > To fix this, chip_good() is enough and it should timeout if it stay > bad for a while. > > Fixes: dfeae107