Re: [PATCH v2] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2015-01-02 Thread Chen Gang
Could you provide more detail for it, then I can make patch v3 (or I have no any idea about it). Thanks 发自我的 iPad > 在 2014年12月30日,下午8:45,Christoph Hellwig 写道: > >> On Mon, Dec 15, 2014 at 12:05:22AM +0800, Chen Gang wrote: >> For shared inline functions crossed source files, better to let

Re: [PATCH v2] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2015-01-02 Thread Chen Gang
Could you provide more detail for it, then I can make patch v3 (or I have no any idea about it). Thanks 发自我的 iPad 在 2014年12月30日,下午8:45,Christoph Hellwig h...@infradead.org 写道: On Mon, Dec 15, 2014 at 12:05:22AM +0800, Chen Gang wrote: For shared inline functions crossed source files,

Re: [PATCH v2] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-12-30 Thread Christoph Hellwig
On Mon, Dec 15, 2014 at 12:05:22AM +0800, Chen Gang wrote: > For shared inline functions crossed source files, better to let it as > "static inline" in a header file. For extern functions, better to > declare them in header file. This one doesn't apply. -- To unsubscribe from this list: send the

Re: [PATCH v2] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-12-30 Thread Christoph Hellwig
On Mon, Dec 15, 2014 at 12:05:22AM +0800, Chen Gang wrote: For shared inline functions crossed source files, better to let it as static inline in a header file. For extern functions, better to declare them in header file. This one doesn't apply. -- To unsubscribe from this list: send the line

RE: [PATCH v2] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-12-15 Thread Sumit Saxena
>-Original Message- >From: Chen Gang [mailto:gang.chen.5...@gmail.com] >Sent: Sunday, December 14, 2014 9:35 PM >To: megaraidli...@lsi.com; jbottom...@parallels.com; Sumit Saxena >Cc: linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org >Subject: [PATCH v2] drivers: scsi: megaraid: Add

RE: [PATCH v2] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-12-15 Thread Sumit Saxena
-Original Message- From: Chen Gang [mailto:gang.chen.5...@gmail.com] Sent: Sunday, December 14, 2014 9:35 PM To: megaraidli...@lsi.com; jbottom...@parallels.com; Sumit Saxena Cc: linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH v2] drivers: scsi: megaraid: Add