Re: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names

2017-11-20 Thread Cyrille Pitchen
Hi Geert, Le 20/11/2017 à 09:49, Geert Uytterhoeven a écrit : > Hi Cyrille, > > On Fri, Nov 17, 2017 at 6:36 PM, Cyrille Pitchen > wrote: >> sorry but I won't apply this patch. >> >> New values for the 'compatible' DT properties should only be added for >> memory parts not supporting the JEDEC R

Re: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names

2017-11-20 Thread Geert Uytterhoeven
Hi Fabrizio, On Mon, Nov 20, 2017 at 10:43 AM, Fabrizio Castro wrote: >> On Fri, Nov 17, 2017 at 6:36 PM, Cyrille Pitchen >> wrote: >> BTW, "sst" (for Silicon Storage Technology) should be added to >> Documentation/devicetree/bindings/vendor-prefixes.txt, too, to avoid another >> warning: >> >>

RE: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names

2017-11-20 Thread Fabrizio Castro
Dear All, > Subject: Re: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of > supported chip names > > Hi Cyrille, > > On Fri, Nov 17, 2017 at 6:36 PM, Cyrille Pitchen > wrote: > > sorry but I won't apply this patch. > > > > New values for t

Re: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names

2017-11-20 Thread Geert Uytterhoeven
Hi Cyrille, On Fri, Nov 17, 2017 at 6:36 PM, Cyrille Pitchen wrote: > sorry but I won't apply this patch. > > New values for the 'compatible' DT properties should only be added for > memory parts not supporting the JEDEC READ ID (0x9F) command. I tent to disagree. Documenting part numbers in the

Re: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names

2017-11-17 Thread Marek Vasut
On 11/17/2017 06:36 PM, Cyrille Pitchen wrote: > Hi Fabrizio, > > sorry but I won't apply this patch. ACK on that, if it can be detected with READID or SFDP, use that and don't add redundant stuff into the DT bindings. btw which renesas board has this SPI NOR on it ? > New values for the 'compa

RE: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names

2017-11-17 Thread Fabrizio Castro
Hello Cyrille, it's ok, thank you for the feedback. Best regards, Fab > Hi Fabrizio, > > sorry but I won't apply this patch. > > New values for the 'compatible' DT properties should only be added for > memory parts not supporting the JEDEC READ ID (0x9F) command. > > SST25 memories do support th

Re: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names

2017-11-17 Thread Cyrille Pitchen
Hi Fabrizio, sorry but I won't apply this patch. New values for the 'compatible' DT properties should only be added for memory parts not supporting the JEDEC READ ID (0x9F) command. SST25 memories do support this command hence should use the "jedec,spi-nor" value alone. For historical reasons, s

RE: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of supported chip names

2017-11-14 Thread Fabrizio Castro
Dear All, how does this patch look like? Thanks, Fabrizio > Subject: [PATCH v2] dt-bindings: mtd: Add sst25vf016b to the list of > supported chip names > > There are a few DT files that make use of sst25vf016b in their > compatible strings, and the driver supports this chip already. > This patc