RE: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()

2014-09-30 Thread Sharma, Sanjeev
jeev > Cc: d...@gentoo.org; k...@deine-taler.de; > linux-wirel...@vger.kernel.org; linux-kernel@vger.kernel.org; > net...@vger.kernel.org > Subject: Re: [PATCH v2] zd1211rw: replace ZD_ASSERT with > lockdep_assert_held() > > On Thu, 2014-09-11 at 15:39 +0530, Sanjeev Shar

Re: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()

2014-09-14 Thread Julian Calaby
vger.kernel.org; > linux-kernel@vger.kernel.org; net...@vger.kernel.org > Subject: Re: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held() > > On Thu, 2014-09-11 at 15:39 +0530, Sanjeev Sharma wrote: >> on some architecture spin_is_locked() always return false in

Re: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()

2014-09-11 Thread Johannes Berg
On Thu, 2014-09-11 at 10:36 +, Sharma, Sanjeev wrote: > > - ZD_ASSERT(!spin_is_locked(&mac->lock)); > > + lockdep_assert_held(&mac->lock); > >Look closely at this again. > > I didn't understand where I put wrong logic ? Ok, that's fine. But please send a new patch only when you've und

RE: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()

2014-09-11 Thread Sharma, Sanjeev
] zd1211rw: replace ZD_ASSERT with lockdep_assert_held() On Thu, 2014-09-11 at 15:39 +0530, Sanjeev Sharma wrote: > on some architecture spin_is_locked() always return false in > uniprocessor configuration and therefore it would be advise to replace > with lockdep_assert_held(). > >

Re: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()

2014-09-11 Thread Johannes Berg
On Thu, 2014-09-11 at 15:39 +0530, Sanjeev Sharma wrote: > on some architecture spin_is_locked() always return false in > uniprocessor configuration and therefore it would be advise > to replace with lockdep_assert_held(). > > Signed-off-by: Sanjeev Sharma > --- > Changes in v2: > - corrected t