Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-14 Thread Kishon Vijay Abraham I
Hi, On Thursday 14 April 2016 02:21 AM, David Lechner wrote: > On 04/01/2016 08:16 AM, Kishon Vijay Abraham I wrote: > >>> +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); >> >> Don't prefer export symbols from PHY driver. That'll create unnecessary >> dependencies between the controller and the

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-14 Thread Kishon Vijay Abraham I
Hi, On Thursday 14 April 2016 02:21 AM, David Lechner wrote: > On 04/01/2016 08:16 AM, Kishon Vijay Abraham I wrote: > >>> +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); >> >> Don't prefer export symbols from PHY driver. That'll create unnecessary >> dependencies between the controller and the

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-13 Thread David Lechner
On 04/01/2016 08:16 AM, Kishon Vijay Abraham I wrote: +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); Don't prefer export symbols from PHY driver. That'll create unnecessary dependencies between the controller and the PHY. I think it'll be better to create a new attribute and use it? Just

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-13 Thread David Lechner
On 04/01/2016 08:16 AM, Kishon Vijay Abraham I wrote: +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); Don't prefer export symbols from PHY driver. That'll create unnecessary dependencies between the controller and the PHY. I think it'll be better to create a new attribute and use it? Just

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Bin Liu
Hi, On Fri, Apr 01, 2016 at 10:45:47PM +0300, Sergei Shtylyov wrote: > On 04/01/2016 07:02 PM, David Lechner wrote: > > +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); > >>> > >>>Don't prefer export symbols from PHY driver. That'll create unnecessary > >>>dependencies between the controller

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Bin Liu
Hi, On Fri, Apr 01, 2016 at 10:45:47PM +0300, Sergei Shtylyov wrote: > On 04/01/2016 07:02 PM, David Lechner wrote: > > +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); > >>> > >>>Don't prefer export symbols from PHY driver. That'll create unnecessary > >>>dependencies between the controller

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Sergei Shtylyov
On 04/01/2016 07:19 PM, Bin Liu wrote: +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); Don't prefer export symbols from PHY driver. That'll create unnecessary dependencies between the controller and the PHY. Agreed. I think it'll be better to create a new attribute and use it? Another

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Sergei Shtylyov
On 04/01/2016 07:19 PM, Bin Liu wrote: +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); Don't prefer export symbols from PHY driver. That'll create unnecessary dependencies between the controller and the PHY. Agreed. I think it'll be better to create a new attribute and use it? Another

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Sergei Shtylyov
On 04/01/2016 07:02 PM, David Lechner wrote: +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); Don't prefer export symbols from PHY driver. That'll create unnecessary dependencies between the controller and the PHY. Agreed. I think it'll be better to create a new attribute and use it?

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Sergei Shtylyov
On 04/01/2016 07:02 PM, David Lechner wrote: +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); Don't prefer export symbols from PHY driver. That'll create unnecessary dependencies between the controller and the PHY. Agreed. I think it'll be better to create a new attribute and use it?

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Bin Liu
Hi, On Fri, Apr 01, 2016 at 11:02:23AM -0500, David Lechner wrote: > On 04/01/2016 09:45 AM, Bin Liu wrote: > >>>+EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); > >> > >>Don't prefer export symbols from PHY driver. That'll create unnecessary > >>dependencies between the controller and the PHY. > >

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Bin Liu
Hi, On Fri, Apr 01, 2016 at 11:02:23AM -0500, David Lechner wrote: > On 04/01/2016 09:45 AM, Bin Liu wrote: > >>>+EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); > >> > >>Don't prefer export symbols from PHY driver. That'll create unnecessary > >>dependencies between the controller and the PHY. > >

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread David Lechner
On 04/01/2016 09:45 AM, Bin Liu wrote: +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); Don't prefer export symbols from PHY driver. That'll create unnecessary dependencies between the controller and the PHY. Agreed. I think it'll be better to create a new attribute and use it? Another

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread David Lechner
On 04/01/2016 09:45 AM, Bin Liu wrote: +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode); Don't prefer export symbols from PHY driver. That'll create unnecessary dependencies between the controller and the PHY. Agreed. I think it'll be better to create a new attribute and use it? Another

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Bin Liu
Hi, On Fri, Apr 01, 2016 at 06:46:28PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > > This is a new phy driver for the SoC USB controllers on the TI DA8XX > > family of microcontrollers. The USB 1.1 PHY is just a simple on/off. > > The

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Bin Liu
Hi, On Fri, Apr 01, 2016 at 06:46:28PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > > This is a new phy driver for the SoC USB controllers on the TI DA8XX > > family of microcontrollers. The USB 1.1 PHY is just a simple on/off. > > The

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Kishon Vijay Abraham I
Hi, On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > This is a new phy driver for the SoC USB controllers on the TI DA8XX > family of microcontrollers. The USB 1.1 PHY is just a simple on/off. > The USB 2.0 PHY also allows overriding the VBUS and ID pins. > > Signed-off-by: David

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-04-01 Thread Kishon Vijay Abraham I
Hi, On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > This is a new phy driver for the SoC USB controllers on the TI DA8XX > family of microcontrollers. The USB 1.1 PHY is just a simple on/off. > The USB 2.0 PHY also allows overriding the VBUS and ID pins. > > Signed-off-by: David

RE: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-24 Thread David Laight
From: David Lechner > Sent: 23 March 2016 18:07 > On 03/23/2016 12:21 PM, Sekhar Nori wrote: > >> +/* DA8xx CFGCHIP2 (USB PHY Control) register bits */ > >> +#define PHYCLKGD (1 << 17) > >> +#define VBUSSENSE (1 << 16) > >> +#define RESET (1 << 15) > >>

RE: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-24 Thread David Laight
From: David Lechner > Sent: 23 March 2016 18:07 > On 03/23/2016 12:21 PM, Sekhar Nori wrote: > >> +/* DA8xx CFGCHIP2 (USB PHY Control) register bits */ > >> +#define PHYCLKGD (1 << 17) > >> +#define VBUSSENSE (1 << 16) > >> +#define RESET (1 << 15) > >>

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-23 Thread David Lechner
On 03/23/2016 12:21 PM, Sekhar Nori wrote: +/* DA8xx CFGCHIP2 (USB PHY Control) register bits */ +#define PHYCLKGD (1 << 17) +#define VBUSSENSE (1 << 16) +#define RESET (1 << 15) +#define OTGMODE_MASK (3 << 13) +#define NO_OVERRIDE

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-23 Thread David Lechner
On 03/23/2016 12:21 PM, Sekhar Nori wrote: +/* DA8xx CFGCHIP2 (USB PHY Control) register bits */ +#define PHYCLKGD (1 << 17) +#define VBUSSENSE (1 << 16) +#define RESET (1 << 15) +#define OTGMODE_MASK (3 << 13) +#define NO_OVERRIDE

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-23 Thread Sekhar Nori
On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > This is a new phy driver for the SoC USB controllers on the TI DA8XX > family of microcontrollers. The USB 1.1 PHY is just a simple on/off. > The USB 2.0 PHY also allows overriding the VBUS and ID pins. > > Signed-off-by: David Lechner

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-23 Thread Sekhar Nori
On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > This is a new phy driver for the SoC USB controllers on the TI DA8XX > family of microcontrollers. The USB 1.1 PHY is just a simple on/off. > The USB 2.0 PHY also allows overriding the VBUS and ID pins. > > Signed-off-by: David Lechner

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-19 Thread Sergei Shtylyov
On 3/17/2016 5:26 AM, David Lechner wrote: This is a new phy driver for the SoC USB controllers on the TI DA8XX DA8xx, please. family of microcontrollers. The USB 1.1 PHY is just a simple on/off. The USB 2.0 PHY also allows overriding the VBUS and ID pins. Signed-off-by: David Lechner

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-19 Thread Sergei Shtylyov
On 3/17/2016 5:26 AM, David Lechner wrote: This is a new phy driver for the SoC USB controllers on the TI DA8XX DA8xx, please. family of microcontrollers. The USB 1.1 PHY is just a simple on/off. The USB 2.0 PHY also allows overriding the VBUS and ID pins. Signed-off-by: David Lechner