RE: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

2016-08-08 Thread Peter Chen
>Quoting Peter Chen (2016-08-06 00:54:35) >> On Fri, Aug 05, 2016 at 02:53:56PM -0700, Stephen Boyd wrote: >> > Quoting Peter Chen (2016-07-08 02:45:28) >> > > On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: >> > > > We don't call hw_device_reset() with the ci->lock held, so it >> > >

Re: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

2016-08-06 Thread Peter Chen
On Fri, Aug 05, 2016 at 02:53:56PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-07-08 02:45:28) > > On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: > > > We don't call hw_device_reset() with the ci->lock held, so it > > > doesn't seem like this lock here is protecting anythin

Re: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

2016-07-08 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: > We don't call hw_device_reset() with the ci->lock held, so it > doesn't seem like this lock here is protecting anything. Let's > just remove it. This allows us to call sleeping functions like > phy_init() from within the CI_HDRC_CONTRO