Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread robin
On 2019-08-29 13:50, Marco Felsch wrote: On 19-08-29 09:11, Robin Gong wrote: On 2019-08-29 16:17, Marco Felsch wrote: > > > While reading the rm it seems that > > > the snvs block has a dedicated version register. IMHO this could be > > > a better way to apply the change also to existing

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread Marco Felsch
On 19-08-29 09:11, Robin Gong wrote: > > On 2019-08-29 16:17, Marco Felsch wrote: > > > > While reading the rm it seems that > > > > the snvs block has a dedicated version register. IMHO this could be > > > > a better way to apply the change also to existing devices with old > > > > firmware. > >

RE: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread Robin Gong
On 2019-08-29 16:17, Marco Felsch wrote: > > > While reading the rm it seems that > > > the snvs block has a dedicated version register. IMHO this could be > > > a better way to apply the change also to existing devices with old > > > firmware. > > > > I thought the same thing, and fully agree

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread Marco Felsch
Hi Robin, On 19-08-29 09:24, robin wrote: > Hi Marco, > > On 2019-08-28 11:15, Marco Felsch wrote: > > Hi Robin, > > > > thanks for the patch. > > > > On 19-08-27 14:32, Robin van der Gracht wrote: > > > The first generation i.MX6 processors does not send an interrupt > > > when the > > >

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread robin
Hi Marco, On 2019-08-28 11:15, Marco Felsch wrote: Hi Robin, thanks for the patch. On 19-08-27 14:32, Robin van der Gracht wrote: The first generation i.MX6 processors does not send an interrupt when the power key is pressed. It sends a power down request interrupt if the key is released

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-28 Thread Marco Felsch
Hi Robin, thanks for the patch. On 19-08-27 14:32, Robin van der Gracht wrote: > The first generation i.MX6 processors does not send an interrupt when the > power key is pressed. It sends a power down request interrupt if the key is > released before a hard shutdown (5 second press). This should