Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-04 Thread Hans de Goede
Hi, On 2/16/21 8:24 AM, Perry Yuan wrote: > Hi Hans: > > On 2021/1/13 2:37, Hans de Goede wrote: >> Hi, >> >> I know there already is a v3 out and I will try to get around to reviewing >> that soon, still 1 remark about the discussion surrounding v2: >> >> On 1/11/21 2:42 PM, Perry Yuan wrote: >>

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-02-15 Thread Perry Yuan
Hi Hans: On 2021/1/13 2:37, Hans de Goede wrote: Hi, I know there already is a v3 out and I will try to get around to reviewing that soon, still 1 remark about the discussion surrounding v2: On 1/11/21 2:42 PM, Perry Yuan wrote: *The flow is like this: 1) User presses key. HW does stuff wi

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-14 Thread Perry Yuan
On 2021/1/13 2:37, Hans de Goede wrote: Hi, I know there already is a v3 out and I will try to get around to reviewing that soon, still 1 remark about the discussion surrounding v2: On 1/11/21 2:42 PM, Perry Yuan wrote: *The flow is like this: 1) User presses key. HW does stuff with this k

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-12 Thread Hans de Goede
Hi, I know there already is a v3 out and I will try to get around to reviewing that soon, still 1 remark about the discussion surrounding v2: On 1/11/21 2:42 PM, Perry Yuan wrote: >>> *The flow is like this: >>> 1) User presses key. HW does stuff with this key (timeout is started) >>> 2) Event

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-12 Thread Perry Yuan
Hi Barnabás, On 2021/1/12 0:07, Barnabás Pőcze wrote: Hi 2021. január 11., hétfő 14:42 keltezéssel, Perry Yuan írta: [...] +#define PRIVACY_PLATFORM_NAME "dell-privacy-acpi" +#define DELL_PRIVACY_GUID "6932965F-1671-4CEB-B988-D3AB0A901919" + +struct privacy_acpi_priv { + struct

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-11 Thread Barnabás Pőcze
Hi 2021. január 11., hétfő 14:42 keltezéssel, Perry Yuan írta: > [...] > > > +#define PRIVACY_PLATFORM_NAME"dell-privacy-acpi" > > > +#define DELL_PRIVACY_GUID"6932965F-1671-4CEB-B988-D3AB0A901919" > > > + > > > +struct privacy_acpi_priv { > > > + struct device *dev; > > > + struct p

RE: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-08 Thread Yuan, Perry
> -Original Message- > From: Barnabás Pőcze > Sent: 2021年1月8日 0:04 > To: Hans de Goede > Cc: Yuan, Perry; mgr...@linux.intel.com; platform-driver- > x...@vger.kernel.org; linux-kernel@vger.kernel.org; Limonciello, Mario > Subject: Re: [PATCH v2 1/2] platform/x

RE: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-08 Thread Limonciello, Mario
Dell Customer Communication - Confidential Perry, For discussion in public mailing lists you'll have to make sure that you get Dell's mail service to turn off this clause and resend: > > Dell Customer Communication - Confidential >

RE: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-08 Thread Yuan, Perry
ubject: Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell > hardware privacy > > > [EXTERNAL EMAIL] > > Hi > > > 2021. január 7., csütörtök 0:43 keltezéssel, Hans de Goede írta: > > > Hi Perry, > > > > On 12/28/20 2:28 PM,

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-07 Thread Barnabás Pőcze
Hi 2021. január 7., csütörtök 0:43 keltezéssel, Hans de Goede írta: > Hi Perry, > > On 12/28/20 2:28 PM, Perry Yuan wrote: > > > From: Perry Yuan perry_y...@dell.com > > add support for dell privacy driver for the dell units equipped > > hardware privacy design, which protect users privacy > > o

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-06 Thread Hans de Goede
Hi Perry, On 12/28/20 2:28 PM, Perry Yuan wrote: > From: Perry Yuan > > add support for dell privacy driver for the dell units equipped > hardware privacy design, which protect users privacy > of audio and camera from hardware level. once the audio or camera > privacy mode enabled, any applicati

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2020-12-28 Thread Barnabás Pőcze
Hi Firstly, a minor note: the newly created sysfs attributes are not documented, so I believe you should either move them to debugfs or add documentation. And I believe you might have forgotten to send the second patch in the series. I added a couple comments regarding the code, but unfortunatel