Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 12:12 PM, Mani, Rajmohan wrote: >> > +#include >> >> And this is for...? > use by tps68470.c which uses i2c_driver and other such i2c defines. It should be in C-file, not in the header which has nothing to do with I2C APIs. -- With Best Regards, Andy Shevchenko

RE: [PATCH v2 1/3] mfd: Add new mfd device TPS68470

2017-06-12 Thread Mani, Rajmohan
Hi Andy, Thanks for the reviews. > Subject: Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470 > > On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani > wrote: > > The TPS68470 device is an advanced power management unit that powers a > > Compact Camera Module (CCM), ge

Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470

2017-06-11 Thread Andy Shevchenko
On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani wrote: > The TPS68470 device is an advanced power management > unit that powers a Compact Camera Module (CCM), > generates clocks for image sensors, drives a dual > LED for Flash and incorporates two LED drivers for > general purpose indicators. > > T